993318 - [Settings] build script improvement for load time

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

We'd improve settings load time via

* use better r.js config to minimize production source

And it might worth to remove the data-skip-optimize hack in index.html by create new startup.js (as camera does).

Comment 1

[[e-mail]]

And please append b2gperf load time result in real device with `GAIA_OPTIMIZE=1 make production` build.

Comment 2

[[e-mail]]

Attachment: pull request redirect to github

refer from email app, 

performance test 1684 -> 1648

only do the uglify while production

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8404607 [details] [review]
pull request redirect to github

Thanks for the patch.

I think we should turn off beautify and turn on compress and mangle. That's what webapp-optimize.js does for production builds.

Comment 4

[[e-mail]]

Comment on attachment 8404607 [details] [review]
pull request redirect to github

- use startup.js to load main.js,
- do mangling and compress.
- update to alameda from 0.0.9 to 0.2

got load time 1742 -> 1613

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8404607 [details] [review]
pull request redirect to github

r=me, thank you for the patch!

Comment 6

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/4afcad984ec25595c8acb1eb2660e77615f9955a

thanks!

Comment 7

[Hubert Figuiere [:hub]]

This change breaks make test-perf.

Filed bug 1011168

Comment 8

[Hubert Figuiere [:hub]]

I'll be honest I don't know how it cause breakage. But I do have a fix.