Closed Bug 993318 Opened 6 years ago Closed 6 years ago

[Settings] build script improvement for load time

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S6 (25apr)

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

Attachments

(1 file)

We'd improve settings load time via

* use better r.js config to minimize production source

And it might worth to remove the data-skip-optimize hack in index.html by create new startup.js (as camera does).
And please append b2gperf load time result in real device with `GAIA_OPTIMIZE=1 make production` build.
Target Milestone: --- → 1.4 S6 (25apr)
Assignee: nobody → gasolin
refer from email app, 

performance test 1684 -> 1648

only do the uglify while production
Attachment #8404607 - Flags: review?(arthur.chen)
Comment on attachment 8404607 [details] [review]
pull request redirect to github

Thanks for the patch.

I think we should turn off beautify and turn on compress and mangle. That's what webapp-optimize.js does for production builds.
Attachment #8404607 - Flags: review?(arthur.chen)
Comment on attachment 8404607 [details] [review]
pull request redirect to github

- use startup.js to load main.js,
- do mangling and compress.
- update to alameda from 0.0.9 to 0.2

got load time 1742 -> 1613
Attachment #8404607 - Flags: review?(arthur.chen)
Comment on attachment 8404607 [details] [review]
pull request redirect to github

r=me, thank you for the patch!
Attachment #8404607 - Flags: review?(arthur.chen) → review+
merged https://github.com/mozilla-b2g/gaia/commit/4afcad984ec25595c8acb1eb2660e77615f9955a

thanks!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
This change breaks make test-perf.

Filed bug 1011168
I'll be honest I don't know how it cause breakage. But I do have a fix.
You need to log in before you can comment on or make changes to this bug.