1011187 - HTML Canvas does not render small-caps font variants

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Simon Sarris]

Setting the canvas font to a small-caps variant does not produce a small-caps effect. 

var can = document.getElementById('canvas1');
var ctx = can.getContext('2d');

ctx.font = "italic small-caps bold 22px verdana, tahoma, serif";
ctx.fillText("Test One Two Three", 50, 50);

Simple example: http://jsfiddle.net/vrS2B/

Other browsers:
  Chrome: Works
  iOS Safari: Works
  IE11: Does not work

Comment 1

[Paul Silaghi, QA [:pauly]]

Confirmed 32.0a1 (2014-05-15), win 7 x64

Comment 2

[Jonathan Kew [:jfkthame]]

Fixing this within the current architecture used for small-caps in HTML is hard.

But if we move the implementation of small-caps from layout (nsTextFrame.cpp and nsTextRunTransformations.cpp) over into gfx, making it an attribute of gfxFontStyle that is implemented at rendering time, it'll become trivial.

I have an experimental patch for this refactoring. I'll file a separate bug for that, and tidy up the patch for review; then we can make this dependent on it.

(See also bug 935739 re XUL text.)

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: reftest for font-variant:small-caps in canvas.

This issue is fixed by bug 1015603; here's a reftest for it.

Comment 4

[Jonathan Kew [:jfkthame]]

Testcase:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e8879b65201

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3e8879b65201

Comment 6

[Simon Sarris]

Confirmed working in nightly. You guys are seriously the best in terms of bug response of all the browsers I deal with. By miles and miles.

Thank you so much.

Comment 7

[Paul Silaghi, QA [:pauly]]

verified based on comment 6