1011251 - [B2G][RTL][Settings] Arabic: The 'Change' screen for 'Ringer' and 'Alerts' in 'Sound' settings are left aligned

Status: RESOLVED DUPLICATE of bug 1094450

(Firefox OS Graveyard :: Gaia::Ringtones, defect)

Description

[mhall]

Attachment: logcat of issue

Description:
In the Settings app under the Sound option, the 'Change' screen for 'Ringer' and 'Alerts' are left aligned in the tested language.

Repro Steps:
1) Update a Buri to BuildID: 20140515000202
2) Tap on Settings app from the home screen
3) Tap on Sound
4) Tap on Change under Ringer or tap on Change under Alerts.
5) Observe the 'Change' screen for 'Ringer' and 'Alerts' are left aligned on both screens

Actual:
The 'Change' screen for 'Ringer' and 'Alerts' are left aligned on both screens

Expected:
The 'Change' screen for 'Ringer' and 'Alerts' are right aligned on both screens

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140515000202
Gaia: 2e97bee6bb79d3577dba1bf2a1bbfcba64ee99ab
Gecko: 0cb91945f404
Version: 30.0
Firmware Version: v1.2-device.cfg

Repro frequency: 100%
Link to failed test case(1 of 2): https://moztrap.mozilla.org/manage/case/12357/
Link to failed test case(2 of 2): https://moztrap.mozilla.org/manage/case/12359/
See attached: screenshot

Comment 1

[mhall]

Attachment: Screen shot

1.3 Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140514024003
Gaia: 96e3fa769a436a2182e6d54088fb41386eb2b5b5
Gecko: 685cf1d0dedb
Version: 28.0
Firmware Version: v1.2-device.cfg

Under settings in 'Sound' the 'Change' screen for 'Ringer' and 'Alerts' in   are left aligned in the Buri 1.3 MOZ RIL.

Comment 2

[Stephany Wilkes]

Attachment: 2014-09-23-18-22-24.png

Ahmed, I believe this issue is fixed, per the attached screenshot. Can you please verify, and/or recommend any other RTL changes for this screen? For example, are the selection dots OK where they are, or should they be farther to the left, etc? Thanks!

Comment 3

[Ahmed Nefzaoui [:Nefzaoui]]

Yes :)
The radio buttons should be on the far right, just before the text just like they are on the far left in the case of LTR.
Adding a PR..

Comment 4

[Ahmed Nefzaoui [:Nefzaoui]]

Attachment: Link to Github pull-request

The issue is basically BB lacking a little bit of RTL polish.
But since it's related to both and I did changes on both sides (Ringtones and BB) I guess I need both Modules owners/peers' reviews.
Ismael and David, can you review that for me please?
Thanks! :)

Comment 5

[Ahmed Nefzaoui [:Nefzaoui]]

Attachment: After Patch - 2014-09-24-23-36-02

Stephany,
How does that look ? :)
Thanks

Comment 6

[David Flanagan [:djf]]

Comment on attachment 8494598 [details]
Link to Github pull-request

Passing the review on to Jim who is the ringtones module owner now.

Comment 7

[Jim Porter (:squib)]

Comment on attachment 8494598 [details]
Link to Github pull-request

I guess this looks ok, although I can't really say whether this does what we want, since I have at best a vague understanding of what RTL stuff should look like.

Comment 8

[Stephany Wilkes]

Comment on attachment 8494599 [details]
After Patch - 2014-09-24-23-36-02

Much better. Thank you! Approved and +.

Comment 9

[Jim Porter (:squib)]

I'm not sure this patch is correct anymore, and since it was never landed, I inadvertently filed and posted a PR for this to bug 1094450. I propose we close this bug in favor of mine, since my patch is newer (and addresses a few things the patch here doesn't).

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Clear the flag as the issue is actually in the ringtone app.

Comment 11

[Jim Porter (:squib)]

Yeah, I think this is just bug 1094450. Marking dup. If there's anything I missed, let me know.

Comment 12

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15501/