1011326 - [MADAI][Bluetooth] The search button is still "searching..." even after discovery completed.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect, P3)

Description

[ILBEOM KIM]

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.131 Safari/537.36

Steps to reproduce:

1. Entering the Bluetooth setting menu
2. Try to the discovery start("Search for devices" button)
3. Waiting until discovery completed


Actual results:

Search  button is still disabled


Expected results:

Search button is enabled after discovery completed

Comment 1

[ILBEOM KIM]

Attachment: SearchButtonDisabled.txt

Dear Mozilaa Engineer.

This case isn't updating the search button.

The discovery completed event is occurred in the bluedroid.
And discovery_state_changed_cb is called but the return value don't send to the gaia layer.

Because the sChangedDiscoveryRunnableArray is the empty array in the DiscoveryStateChangedCallback.

Could you help me to solve this case?

Thank you for your support.

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Eric,
This looks like bug 942104, shall we rebase the patch again?

Comment 3

[Eric Chou [:ericchou] [:echou]]

(In reply to Shawn Huang [:shuang] [:shawnjohnjr] from comment #2)
> Eric,
> This looks like bug 942104, shall we rebase the patch again?

Yes, we should restart the implementation of bug 942104. Thanks for reporting this.

Comment 4

[Preeti Raghunath(:Preeti)]

Eric,

Can you please weigh in on risk analysis the same?

Comment 5

[Eric Chou [:ericchou] [:echou]]

Hi Preeti,

(In reply to Preeti Raghunath(:Preeti) from comment #4)
> Eric,
> 
> Can you please weigh in on risk analysis the same?

This is a bug that we need to solve with no doubt, otherwise Bluetooth discovery would not be able to be re-triggered. Actually we have already opened 2 issues, bug 942104(gecko part) and bug 945631(Gaia part), to fix the same problem. Once they get fixed, this issue would be gone as well. Patches for Bug 942104 all got r+ this morning, and I've already had a solution for bug 945631 as well, so "low-risk" would be the answer from my point of view.

Comment 6

[Eric Chou [:ericchou] [:echou]]

(In reply to Eric Chou [:ericchou] [:echou] from comment #5)
> Hi Preeti,
> 
> (In reply to Preeti Raghunath(:Preeti) from comment #4)
> > Eric,
> > 
> > Can you please weigh in on risk analysis the same?
> 
> This is a bug that we need to solve with no doubt, otherwise Bluetooth
> discovery would not be able to be re-triggered. Actually we have already
> opened 2 issues, bug 942104(gecko part) and bug 945631(Gaia part), to fix
> the same problem. Once they get fixed, this issue would be gone as well.
> Patches for Bug 942104 all got r+ this morning, and I've already had a
> solution for bug 945631 as well, so "low-risk" would be the answer from my
> point of view.

Both blockers have been resolved. I just tried the latest gecko:m-c/gaia:master and I can confirm that this issue has been fixed. 1.4 should be fixed as well once bug 945631 is uplifted. Please re-test after that. Thanks.

Comment 7

[Eric Chou [:ericchou] [:echou]]

Hi Ilbeom,

Bug 945631 has been uplifted to 1.4. Please confirm if this issue has been fixed as well. Thank you.

Comment 8

[Tapas[:tkundu on #b2g/gaia/memshrink/gfx] (always NI me)]

:echou, issue is still present on v1.4 even after landing Bug 945631

STR is same as #comment 0

Gaia UI re-activate "search for devices" icon only for 60 secs delay. It takes 60 sec delay even if bluetooth search is completed within 30 secs.

Comment 9

[Eric Chou [:ericchou] [:echou]]

(In reply to Tapas Kumar Kundu from comment #8)
> :echou, issue is still present on v1.4 even after landing Bug 945631
> 
> STR is same as #comment 0
> 
> Gaia UI re-activate "search for devices" icon only for 60 secs delay. It
> takes 60 sec delay even if bluetooth search is completed within 30 secs.

I just flashed the latest 1.4 gecko/gaia to my Nexus 5 (because I need a device running Bluedroid) and gave it a test, it looked good. The search button was lighted again once the search was done. Could you please double check that patches for 942104 and 945631 are in the codebase you use?

Besides, you mentioned that on your device Bluetooth search is completed within '30' seconds, which is different from Android's default(12 secs). I was wondering if CAF modified the length of inquiry.

Comment 10

[Tapas[:tkundu on #b2g/gaia/memshrink/gfx] (always NI me)]

(In reply to Eric Chou [:ericchou] [:echou] from comment #9)
> (In reply to Tapas Kumar Kundu from comment #8)
> > :echou, issue is still present on v1.4 even after landing Bug 945631
> > 
> > STR is same as #comment 0
> > 
> > Gaia UI re-activate "search for devices" icon only for 60 secs delay. It
> > takes 60 sec delay even if bluetooth search is completed within 30 secs.
> 
> I just flashed the latest 1.4 gecko/gaia to my Nexus 5 (because I need a
> device running Bluedroid) and gave it a test, it looked good. The search
> button was lighted again once the search was done. Could you please double
> check that patches for 942104 and 945631 are in the codebase you use?
> 
> Besides, you mentioned that on your device Bluetooth search is completed
> within '30' seconds, which is different from Android's default(12 secs). I
> was wondering if CAF modified the length of inquiry.

Thanks for the info that it is working in bluez. I am just checking with my colleague on this. It may be that gaia/gecko bug is fixed but bludroid bug is causing some delay. I will confirm and update here asap.

Comment 11

[ILBEOM KIM]

(In reply to Eric Chou [:ericchou] [:echou] from comment #7)
> Hi Ilbeom,
> 
> Bug 945631 has been uplifted to 1.4. Please confirm if this issue has been
> fixed as well. Thank you.

Dear eric.

I checked out your solution and the search button is very well changed.

Thanks you for your support.

Comment 12

[Eric Chou [:ericchou] [:echou]]

(In reply to ILBEOM KIM from comment #11)
> (In reply to Eric Chou [:ericchou] [:echou] from comment #7)
> > Hi Ilbeom,
> > 
> > Bug 945631 has been uplifted to 1.4. Please confirm if this issue has been
> > fixed as well. Thank you.
> 
> Dear eric.
> 
> I checked out your solution and the search button is very well changed.
> 
> Thanks you for your support.

Good to know. :)

Comment 13

[Eric Chou [:ericchou] [:echou]]

(In reply to Tapas Kumar Kundu from comment #10)
> (In reply to Eric Chou [:ericchou] [:echou] from comment #9)
> > (In reply to Tapas Kumar Kundu from comment #8)
> > > :echou, issue is still present on v1.4 even after landing Bug 945631
> > > 
> > > STR is same as #comment 0
> > > 
> > > Gaia UI re-activate "search for devices" icon only for 60 secs delay. It
> > > takes 60 sec delay even if bluetooth search is completed within 30 secs.
> > 
> > I just flashed the latest 1.4 gecko/gaia to my Nexus 5 (because I need a
> > device running Bluedroid) and gave it a test, it looked good. The search
> > button was lighted again once the search was done. Could you please double
> > check that patches for 942104 and 945631 are in the codebase you use?
> > 
> > Besides, you mentioned that on your device Bluetooth search is completed
> > within '30' seconds, which is different from Android's default(12 secs). I
> > was wondering if CAF modified the length of inquiry.
> 
> Thanks for the info that it is working in bluez.

My previous comment actually meant 'it's working in bluedroid', however BlueZ should work as well.
(Comment 11 shows that bluedroid does work)

> I am just checking with my
> colleague on this. It may be that gaia/gecko bug is fixed but bludroid bug
> is causing some delay. I will confirm and update here asap.

Thanks. :)

Comment 14

[Tapas[:tkundu on #b2g/gaia/memshrink/gfx] (always NI me)]

(In reply to Eric Chou [:ericchou] [:echou] (GSMA MAE @ Shanghai, 6/10 ~ 6/13) from comment #13)

We found a fix for it in bluedroid stack . Fix will land in latest bluedroid repo [1] soon.

[1] https://www.codeaurora.org/cgit/quic/la/platform/external/bluetooth/bluedroid/log/?h=b2g_kk_3.5

Comment 15

[Eric Chou [:ericchou] [:echou]]

(In reply to Tapas Kumar Kundu from comment #14)
> (In reply to Eric Chou [:ericchou] [:echou] (GSMA MAE @ Shanghai, 6/10 ~
> 6/13) from comment #13)
> 
> We found a fix for it in bluedroid stack . Fix will land in latest bluedroid
> repo [1] soon.
> 
> [1]
> https://www.codeaurora.org/cgit/quic/la/platform/external/bluetooth/
> bluedroid/log/?h=b2g_kk_3.5

Hi Tapas,

Just a friendly reminder: please close this issue once your fix lands and has been verified. Thanks.

Comment 16

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This test case needs to be updated https://moztrap.mozilla.org/manage/case/3499/ to address this bug.

Comment 17

[KTucker [:KTucker][Inactive 3/4/2016]]

Test case updated in moztrap:

https://moztrap.mozilla.org/manage/case/3499/