Closed Bug 945631 Opened 11 years ago Closed 10 years ago

Listen to event "discoverystatechanged"

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.4+, b2g-v1.3 unaffected, b2g-v1.3T unaffected, b2g-v1.4 fixed, b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S3 (6june)
Project Flags:
blocking-b2g 1.4+
Tracking Flags:
Tracking Status
b2g-v1.3 --- unaffected
b2g-v1.3T --- unaffected
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: echou, Assigned: echou)

References

Details

Attachments

(1 file)

Link to https://github.com/mozilla-b2g/gaia/pull/14353
183 bytes, patch
arthurcc
: review+
Details | Diff | Splinter Review 
After bug 942104 landed, Gaia has to listen to event "discoverystatechanged" to notice the change of discovery state (from start to stop and vice versa). After this event was introduced, the DOM request returned while calling StartDiscovery/StopDiscovery does not represent if the discovery state is changed anymore.

Please see bug 942104 for more details, such as why we need this change.
Assignee: nobody → echou
Talked to Evelyn last Friday, we couldn't reach a consensus on how StartDiscovery/StopDiscovery API should be designed. We've decided to postpone the review after new Bluetooth API is ready (it's planned to be done by Firefox OS 1.4).
Attachment #8342274 - Flags: review?(ehung)
Depends on: 942104
Blocks: 1011326
blocking-b2g: --- → 1.4+
Comment on attachment 8342274 [details] [diff] [review]
Link to https://github.com/mozilla-b2g/gaia/pull/14353

Since bug 942104 has landed, this should be the next. This patch is gaia implementation to handle discovery state changed event.

Request for review again.
Attachment #8342274 - Flags: review?(arthur.chen)
Comment on attachment 8342274 [details] [diff] [review]
Link to https://github.com/mozilla-b2g/gaia/pull/14353

Thanks for the patch Eric. Please check my comments in github.
Attachment #8342274 - Flags: review?(arthur.chen)
Comment on attachment 8342274 [details] [diff] [review]
Link to https://github.com/mozilla-b2g/gaia/pull/14353

* Patch updated.
Attachment #8342274 - Flags: review?(arthur.chen)
Comment on attachment 8342274 [details] [diff] [review]
Link to https://github.com/mozilla-b2g/gaia/pull/14353

r=me, please land with green travis, thanks!
Attachment #8342274 - Flags: review?(arthur.chen) → review+
(In reply to Arthur Chen [:arthurcc] from comment #6)
> Comment on attachment 8342274 [details] [diff] [review]
> Link to https://github.com/mozilla-b2g/gaia/pull/14353
> 
> r=me, please land with green travis, thanks!

Thanks for prompt review! Will land after bug 942104 re-land.
Merged to trunk

https://github.com/mozilla-b2g/gaia/commit/b9cae2587f53c766cadab5a7575dbec9b054849e

Waiting to be merged into 1.4.
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v1.3: --- → unaffected
status-b2g-v1.3T: --- → unaffected
status-b2g-v1.4: --- → affected
status-b2g-v2.0: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: