1011340 - Support Multicast DNS (mDNS)

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: mdns.patch

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: mdns.patch

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: mdns.patch

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

The patch itself is not too bad, and I have a few nits. Since we don't have anything to test this with, or tests yet, I am not in a hurry to get it into the tree. Are you? (I just wanted to check)

I am more interested in getting bug 1008436 ready to go first.

When we come back to this patch, we need to think about how SSDP and mDNS will live together. I was thinking about a NetworkDiscoveryService that plugged in the current SSDP and mDNS code so they could work together. External code would just need to use NetworkDiscoveryService and not SSDP or mDNS directly.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Mark Finkle (:mfinkle) from comment #3)
> The patch itself is not too bad, and I have a few nits. Since we don't have
> anything to test this with, or tests yet, I am not in a hurry to get it into
> the tree. Are you? (I just wanted to check)
Nope, no rush. I have tested it with an addon to discover the chromecast on my network. I commented on bug 901803 that I"d rather do the discovery of chromecasts either by our SSDP or mDNS js code (with a slight preference for the mDNS code).

> 
> I am more interested in getting bug 1008436 ready to go first.
> 
> When we come back to this patch, we need to think about how SSDP and mDNS
> will live together. I was thinking about a NetworkDiscoveryService that
> plugged in the current SSDP and mDNS code so they could work together.
> External code would just need to use NetworkDiscoveryService and not SSDP or
> mDNS directly.

That sounds right.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8424142 [details] [diff] [review]
mdns.patch

Just dropping review for this until we know we need it for something explicitly

Comment 6

[Vincent Chang[:vchang][changyihsin]]

Hi Mark and Brad, I heard from FFOS product team that MozShare may need mDns to find other sharing apps/devices through use of DNS-SD on top of wifi ad-hoc or wifi direct networks. Android has its implementation based on mdnsresponder in below link.  

http://androidxref.com/4.4.4_r1/xref/external/mdnsresponder/ 

Not sure if we need to expose web APIs to web content as a follow-up bug.

Comment 7

[Patrick McManus [:mcmanus]]

there has been some discussion on doing mdns to support proxy discovery too.. so adding it to the necko backlog at least

https://etherpad.mozilla.org/NeckoBacklog

Comment 8

[Justin D'Arcangelo [:justindarc]]

Setting NI? for myself as a reminder to take a closer look at this patch.

Comment 9

[Justin D'Arcangelo [:justindarc]]

Bulk-clearing old NI? requests. If this still needs my attention, please re-flag me. Thanks.

Comment 10

[Koala Yeung]

Hi. Is there any update on this? What is blocking the patch?

Comment 11

[Santiago Saavedra]

It seems this patchset https://hg.mozilla.org/releases/mozilla-release/rev/3ddbb13a5573 removed mDNS support from Firefox, due to bug https://bugzilla.mozilla.org/show_bug.cgi?id=1215012

Are these two bugs related? I'm looking for support in Firefox to resolve someaddress.local and found FlyWeb (https://wiki.mozilla.org/FlyWeb).

In the table, it seems there is a "Implement JS fallback mDNS implementation (Android, Windows)" task that is marked "on target", but since that's from 2016 I wonder if the page has not been updated.

What's needed to resolve mDNS domains from the Firefox address bar?

Comment 12

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.