Closed
Bug 1011422
Opened 10 years ago
Closed 10 years ago
[B2G][WebRTC] Handle input resolution change by restarting OMX encoder.
Categories
(Core :: WebRTC: Audio/Video, defect)
Tracking
()
People
(Reporter: jhlin, Assigned: jhlin)
References
Details
Attachments
(1 file, 1 obsolete file)
937 bytes,
patch
|
jhlin
:
review+
|
Details | Diff | Splinter Review |
Encoder (at least QCOM's implementation) doesn't support dynamic input resolution change. It takes 200~300ms to restart the encoder so seems an acceptable workaround.
Assignee | ||
Comment 1•10 years ago
|
||
Failed to clear mOMXConfigure in Release() so encoder will never get configured. (-_-;)
Attachment #8423750 -
Flags: review?(rjesup)
Updated•10 years ago
|
Attachment #8423750 -
Flags: review?(rjesup) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Update commit message & carry r+ from jesup.
Attachment #8423750 -
Attachment is obsolete: true
Attachment #8424536 -
Flags: review+
Assignee | ||
Comment 3•10 years ago
|
||
Try result: https://tbpl.mozilla.org/?tree=Try&rev=5fa1a10d160f
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/207ddc4b0cd0
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/207ddc4b0cd0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Updated•10 years ago
|
feature-b2g: --- → 2.0
You need to log in
before you can comment on or make changes to this bug.
Description
•