1011468 - MediaQueryList::Matches needs to flush (for layout changes between Window.matchMedia() and MediaQueryList.matches getter)

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect, P5)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Bug 753777 added a flush of layout in the parent frame in the codepath to produce a MediaQueryList object, but there's still no flush if the user calls matchMedia and then later accesses the matches method (with something that changes layout in the parent in between).

We should add such a flush.  (And also check if any other flushes are needed in MediaQueryList.)

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Work in progress at https://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/c24a375e8708/media-query-list-flushes

Comment 2

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This code was modified in bug 1490012, so I'm going to abandon the work-in-progress patch that I've had sitting around for a while at https://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/32fd64a24ed8/media-query-list-flushes .

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Also see bug 1458816.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1011468 - Flush parent document layout if needed for viewport dependent media queries. r=dholbert,#layout

This is necessary to properly report changes in our document.

The remaining failures are about change event scheduling, which is a
pre-existing issue. Will fix, but in a separate bug.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72f49d2e5d48
Flush parent document layout if needed for viewport dependent media queries. r=dshin

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c9cd4b22aab
Mark test_media_query_list subtest as now passing as expected.

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/72f49d2e5d48
https://hg.mozilla.org/mozilla-central/rev/2c9cd4b22aab