1011831 - Support <template> element in XHTML parser.

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[William Chen [:wchen]]

It turns out that we still use the old parser to parse XHTML document as XML when the mime type is application/xhtml+xml and the old parser does not have support for <template> elements:

http://dxr.mozilla.org/mozilla-central/source/content/html/document/src/nsHTMLDocument.cpp#569

Comment 1

[William Chen [:wchen]]

Attachment: Support <template> element in XHTML parser.

Handle the <template> element as specified for XHTML documents.

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-xhtml-syntax.html#parsing-xhtml-documents

Comment 2

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

Comment on attachment 8424282 [details] [diff] [review]
Support <template> element in XHTML parser.

I guess we still need another bug&patch for XSLT...

Comment 3

[William Chen [:wchen]]

Attachment: Support <template> element in XHTML parser. v2

I've changed the approach for fixing this bug. It now pushes template content onto the stack instead of the template element. There were a couple places that would count the number of children of the node at the top of the stack and it would get the number wrong if we pushed the template element instead of the template contents. This new patch is also closer to what we do in the HTML parser for handing the template element. Also added some tests.

Follow up bug for the XSLT issue here: Bug 1016720

Comment 4

[William Chen [:wchen]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc79f34a19f1

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/cf1c0ce583ce for somehow breaking OSX devtools-1: https://tbpl.mozilla.org/php/getParsedLog.php?id=40772856&tree=Mozilla-Inbound

Comment 6

[William Chen [:wchen]]

Attachment: Part 2: Update serializer to handle template element

It turns out that we use a different serializer for xhtml parsed as xml that needs to be updated, and this was causing the failure in dev tools.

I've updated the iterative serializer in nsDocumentEncoder to step into template contents, similar to what we do in the FragmentOrElement serializer.

Comment 7

[William Chen [:wchen]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb20c1b53118

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cb20c1b53118