1080029 - html template tag does not work on a XUL page

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

I was working on bug 1079434 and ran into this.

You can use the diff I created there, I expected it to just work, but it is failing on the `let inputs = template.content.querySelectorAll("input");` bit, returning a length of 0 and I expect a length of 2.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: template-xul.diff

Comment 2

[Boris Zbarsky [:bzbarsky]]

The magic support for putting things in the .content instead of the actual DOM is part of the HTML parsing algorithm.  This document is not being parsed with the HTML parser, but with the XUL parser, so you don't get the magic.  It looks like we hacked nsXMLContentSink to make this work (per the "willful violation of the XML specification" note in HTML), but not the XUL content sink.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Unfortunately, the XUL content sink uses nsXULPrototypeNode as its "current parent" abstraction, which makes things here ... complicated.  In particular, presumably supporting this needs changes to prototype instantiation, not just the parser.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yeah, I don't think making this work is worth it.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

This issue has surfaced in multiple forms lately as we are trying to reduce our dependency on XUL/XBL.

Two cases are:

1) The move from DTD/.properties to Fluent involved use of DOM Overlays which use <template> tag to merge and sanitize DOM Fragments for localization. That works great for HTML, but unfortunately lack of <template> tag in XUL makes it not able to handle XUL. We currently inject HTML elements into XUL for that (<a> and <img> etc.) but that's suboptimal. It would be make the Fluent transition easier and less likely to regress if we could use <template> tag in XUL

2) The XUL Overlay removal also would benefit from ability to use <teplate> tag in XUL ( NI on :bdhal for more detail).

Is there any chance this became less complex to do over the last three years bz?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Nothing about the parsing end of this has changed.

Comment 7

[Brendan Dahl [:bdahl] (84 regression triage)]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #5)
> 2) The XUL Overlay removal also would benefit from ability to use <teplate>
> tag in XUL ( NI on :bdhal for more detail).

I was considering using a template so I could create the downloads panel lazily (see bug 1434077). However, using a hidden="true" for panel appears to be enough to not cause performance issues.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I would need this too for bug 1520350 and I ended up hack my way out with CDATA ... I guess this will be supported automagically when we convert the XUL files to XHTML?

Comment 9

[Brian Grinstead [:bgrins]]

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo; no longer work for MoCo) from comment #8)

I would need this too for bug 1520350 and I ended up hack my way out with CDATA ... I guess this will be supported automagically when we convert the XUL files to XHTML?

I don't think it will, at least not for XHTML docs created via the prototype cache (as added in Bug 1527977).

Perhaps PrototypeDocumentContentSink would give us a better starting point for adding support (dealing with stuff like Comment 3). I'm not sure, but it's quite likely we'll want something like this for lazifying markup for the remaining XBL bindings (see discussion in https://phabricator.services.mozilla.com/D24914#729312). Going to needinfo Brendan for when he gets back to see if we have any new options here.

Comment 10

[Brendan Dahl [:bdahl] (84 regression triage)]

With XHTML the first parse and creation of the prototype document still is done with an XML parser and XUL content sink, so nothing has really changed here.

Comment 11

[Brendan Dahl [:bdahl] (84 regression triage)]

Attachment: Bug 1080029 - Support HTML template in XUL documents. r=smaug

Check if the current parent element is an HTML template element and if it
is, append to the document fragment instead of it.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8235d59e1d86
Support HTML template in XUL documents. r=smaug

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8235d59e1d86