1012618 - B2G release builds should not pull master of external repositories

Status: RESOLVED DUPLICATE of bug 910745

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Ed Morley [:emorley]]

It appears that for release B2G versions we are still pulling the master of various dependencies as part of the build.

eg from:
https://github.com/mozilla-b2g/b2g-manifest/blob/v1.4/emulator.xml

Whilst some repos reference a tag or revsision:
  <project path="hardware/ril" name="platform_hardware_ril" remote="b2g" revision="v1.4"/>
  <project path="external/qemu" name="platform_external_qemu" remote="b2g" revision="v1.4"/>
  <project path="external/freetype" name="platform/external/freetype" revision="15321e16a085b9b5c85cf029aee86bf57b2e65c1" />

Most others do not:
  <project path="external/expat" name="platform/external/expat" />
  <project path="external/fdlibm" name="platform/external/fdlibm" />
  <project path="external/flac" name="platform/external/flac" />
...
  <project path="ndk" name="platform/ndk" />
  <project path="prebuilt" name="platform/prebuilt" revision="aosp-new/master" />
  <project path="system/bluetooth" name="platform/system/bluetooth" />

This seems very risky.

We should update the manifest files on all non-master branches of https://github.com/mozilla-b2g/b2g-manifest to list explicit revisions - and also updated our "create a new B2G release and it's associated repos/tags etc" docs to mention pinning revisions in these files as part of the setup of a new release.

Comment 1

[Aki Sasaki (not active)]

https://bugzilla.mozilla.org/show_bug.cgi?id=910745#c5

Comment 2

[Ed Morley [:emorley]]

This was fixed in a bug 910745 (which was for trunk), so duping over there & will file a new bug for trunk.