1012638 - Broken redirect error page has a badly sized icon

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Robin Whittleton]

Attachment: broken_icon.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:32.0) Gecko/20100101 Firefox/32.0 (Beta/Release)
Build ID: 20140518030203

Steps to reproduce:

Visit a page with a broken redirect (I hit the problem on http://www.gamespot.com/a/forum/temp-forum-slug-25818469/ )


Actual results:

The new icon is way too large, presumably because the text is breaking onto two lines and the SVG icon is sizing to fit.


Expected results:

The icon should be the same height as on the 404 page (see attached screenshots)

Comment 1

[Francesca Ciceri [:madamezou]]

Hi,

I was able to reproduce it in latest Nightly on Debian Sid Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140519030202 CSet: 41a54c8add09.

The image is indeed too large in the broken redirect error page.
Other error pages ("server not found", "unable to connect") look fine.

@Liz: Any idea in which product/component I should put this? I've searched a bit, but I really have no idea :)

Comment 3

[Francesco Lodolo [:flod]]

I think this depends from bug 1009563, and it's going to hit l10n very hard.

For example, in Italian I see this problem more often than English.

Comment 4

[Jonathan Kew [:jfkthame]]

Yes, this is a result of bug 1009563.

IMO, the two-line titles look pretty bad in themselves; such a large "headline" font size is really only suited to a short, single-line title. Can we allow more width here, so that they don't wrap?

Comment 5

[Francesco Lodolo [:flod]]

Attachment: the horror

I don't think it would be safe to assume that a localized string can fit into one line (and these pages are also hard to test).

Comment 6

[Jonathan Kew [:jfkthame]]

OK, so we'd better revert bug 1009563, and perhaps see if we can fix it in a different way. (Sigh.)

Comment 7

[Jonathan Kew [:jfkthame]]

Attachment: ensure info icon stays the proper size even if the title wraps to multiple lines.

Here's an alternative, more robust implementation. Instead of "attaching" the icon to #errorTitle, where the font size for the heading is not yet set (leading to the fragile sizing that bug 1009563 wanted to fix), we can attach it to #errorTitleText and size/position it relative to the header font size. This appears to work fine across varying font sizes and with multi-line titles.

Comment 8

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96f69a915843

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/96f69a915843

Comment 10

[Ryan VanderMeulen [:RyanVM]]

(In reply to Jonathan Kew (:jfkthame) from comment #8)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/96f69a915843

Please land browser patches on fx-team. We hit a merge conflict due to this.

Comment 11

[Jonathan Kew [:jfkthame]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #10)
> (In reply to Jonathan Kew (:jfkthame) from comment #8)
> > https://hg.mozilla.org/integration/mozilla-inbound/rev/96f69a915843
> 
> Please land browser patches on fx-team. We hit a merge conflict due to this.

Sorry about that. I don't keep an fx-team tree around, so inbound is the natural place for me to push. I guess I could have just marked it checkin-needed instead; but then whoever tried to push it (or the other patch involved) would still have encountered the same conflict.

Comment 13

[Francesca Ciceri [:madamezou]]

Hi,

changing it to All/All as per comment 1, so that we will have it verified on all the platforms.

Comment 14

[Francesca Ciceri [:madamezou]]

Hi, 

I verified the fix on:

- Debian Linux x86_64: reproduced on Firefox/32.0 ID:20140519030202 and successfully verified Firefox/32.0 ID:20140522030204 (latest Nightly)

- Windows 7 x86_64: reproduced on Firefox/32.0 ID:20140521 and successfully verified on Firefox/32.0 ID:20140522030204 (latest Nightly)

Marking Verified as I tested 2 out of 3 platforms.


Cheers,
Francesca