Closed Bug 1012645 Opened 6 years ago Closed 3 years ago

WebRTC: DTMF support

Categories

(Core :: WebRTC, defect, P1)

27 Branch
defect

Tracking

()

VERIFIED FIXED
Blocking Flags:

People

(Reporter: rajkumaradass, Unassigned)

References

Details

(Keywords: dev-doc-complete)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.137 Safari/537.36

Steps to reproduce:

Currently Firefox does not support Webrtc DTMF support


Actual results:

Currently Firefox does not support Webrtc DTMF support


Expected results:

It would be good, if we could atleast get the proposed available date for DTMF support or approximate release which will include webrtc DTMF support
This work is not currently scheduled.
Likely it's mostly work on exposing the API to the DOM, as the underlying media/webrtc/trunk code has support for it, and developing tests for it.

patches welcome....
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86_64 → All
So, rumor has it that FF advertises that it does DTMF in the SDP. If that is the case, it seems like at least that should be removed until it does. Have not looked into this myself which I know I should before commenting here ...
(In reply to Cullen Jennings from comment #3)
> So, rumor has it that FF advertises that it does DTMF in the SDP. If that is
> the case, it seems like at least that should be removed until it does.

This was an artifact of some of our previous SDP generation code. We no longer
advertise DTMF.
Or rather, will no longer relatively soon.
backlog: --- → webRTC+
Rank: 45
Priority: -- → P4
Keywords: dev-doc-needed
Summary: Webrtc: DTMF support → WebRTC: DTMF support
Rank: 45 → 19
Priority: P4 → P1
Rank: 19 → 15
Depends on: 1291714
Depends on: 1291715
Depends on: 1313406
With Bug 1313406 landed, DTMF is now enabled by default. I think it's safe to close this and track any problems that show up in new bugs.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
The DTMF is now supported in Firefox 52 Aurora. 
Confirming on Windows 7 x64, Windows 10x64, Ubuntu 14.04x64 and Mac OS X 10.11 using 2017-01-16 DevEdition.
Status: RESOLVED → VERIFIED
QA Contact: cornel.ionce
Documentation should now be complete. I would very much appreciate reviews of the technical accuracy of the content; I’m pinging dminor with a needinfo to request that at least the “Using DTMF” article (https://developer.mozilla.org/en-US/docs/Web/API/WebRTC_API/Using_DTMF) be reviewed for accuracy.

Unless I hear otherwise, I consider this documentation complete. If there are flaws in the technical accuracy, please feel free to either:

1. Fix them.

or

2. Set the “dev-doc-complete” keyword back to “dev-doc-needed” and needinfo me to get my attention.

Thanks!

New reference articles:

https://developer.mozilla.org/en-US/docs/Glossary/DTMF
https://developer.mozilla.org/en-US/docs/Web/API/RTCRtpSender/dtmf

https://developer.mozilla.org/en-US/docs/Web/API/RTCDTMFSender
https://developer.mozilla.org/en-US/docs/Web/API/RTCDTMFSender/insertDTMF
https://developer.mozilla.org/en-US/docs/Web/API/RTCDTMFSender/toneBuffer
https://developer.mozilla.org/en-US/docs/Web/API/RTCDTMFSender/ontonechange

https://developer.mozilla.org/en-US/docs/Web/API/RTCDTMFToneChangeEvent
https://developer.mozilla.org/en-US/docs/Web/API/RTCDTMFToneChangeEvent/RTCDTMFToneChangeEvent (constructor)
https://developer.mozilla.org/en-US/docs/Web/API/RTCDTMFToneChangeEvent/tone

https://developer.mozilla.org/en-US/docs/Web/Events/tonechange

New guide/example articles:

https://developer.mozilla.org/en-US/docs/Web/API/WebRTC_API/Using_DTMF

Updated articles:

https://developer.mozilla.org/en-US/docs/Web/API/RTCRtpSender (added the dtmf property)
Flags: needinfo?(dminor)
I made a couple of small edits, but overall, looks good to me :)
Flags: needinfo?(dminor)
You need to log in before you can comment on or make changes to this bug.