Closed Bug 1313406 Opened 3 years ago Closed 3 years ago

Enable DTMF by default

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla52
Tracking Status
firefox52 --- verified

People

(Reporter: dminor, Assigned: dminor)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

We currently have DTMF preffed off. This bug tracks enabling it by default.
Michael, is there any reason we can't try enabling this by default?
Flags: needinfo?(mfroman)
One thing we should probably test is calling a third party that accepts out of band DTMF and checking that things work as expected.
I think after we test with a 3rd party, we can probably try enabling the pref.
Flags: needinfo?(mfroman)
Rank: 15
Priority: -- → P1
After discussion, we're not going to block on testing with a 3rd party.
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Comment on attachment 8808239 [details]
Bug 1313406 - Enable DTMF by default;

https://reviewboard.mozilla.org/r/91082/#review91022
Attachment #8808239 - Flags: review?(rjesup) → review+
https://hg.mozilla.org/mozilla-central/rev/e35ee6e46109
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Confirming across platforms on Fx 52.0a2 (build ID: 20170116004021) that the "media.peerconnection.dtmf.enabled" pref is set to TRUE by default.
Group: core-security
Status: RESOLVED → VERIFIED
QA Contact: cornel.ionce
Not a security bug.

Cornel: was there a reason you flipped the security bit on this bug? If it was accidental maybe you can figure out how you managed to do that so you can avoid it in the future. If it was on purpose then adding a reason to a comment when you do so is a good idea.
Group: core-security
Flags: needinfo?(cornel.ionce)
Oups, that was not intended. My bad, sorry! I'll be more careful before submitting changes.
Flags: needinfo?(cornel.ionce)
That this is enabled by default in 53 is now noted in Firefox 53 for developers, and is mentioned on all the pages documenting DTMF that have been created for bug 1012645.
You need to log in before you can comment on or make changes to this bug.