1313406 - Enable DTMF by default

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Dan Minor [:dminor]]

We currently have DTMF preffed off. This bug tracks enabling it by default.

Comment 1

[Dan Minor [:dminor]]

Michael, is there any reason we can't try enabling this by default?

Comment 2

[Dan Minor [:dminor]]

One thing we should probably test is calling a third party that accepts out of band DTMF and checking that things work as expected.

Comment 3

[Michael Froman [:mjf]]

I think after we test with a 3rd party, we can probably try enabling the pref.

Comment 4

[Dan Minor [:dminor]]

After discussion, we're not going to block on testing with a 3rd party.

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1313406 - Enable DTMF by default;

Review commit: https://reviewboard.mozilla.org/r/91082/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91082/

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8808239 [details]
Bug 1313406 - Enable DTMF by default;

https://reviewboard.mozilla.org/r/91082/#review91022

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e35ee6e46109
Enable DTMF by default; r=jesup

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e35ee6e46109

Comment 9

[Cornel Ionce [:noni] [Hubs QA]]

Confirming across platforms on Fx 52.0a2 (build ID: 20170116004021) that the "media.peerconnection.dtmf.enabled" pref is set to TRUE by default.

Comment 10

[Daniel Veditz [:dveditz]]

Not a security bug.

Cornel: was there a reason you flipped the security bit on this bug? If it was accidental maybe you can figure out how you managed to do that so you can avoid it in the future. If it was on purpose then adding a reason to a comment when you do so is a good idea.

Comment 11

[Cornel Ionce [:noni] [Hubs QA]]

Oups, that was not intended. My bad, sorry! I'll be more careful before submitting changes.

Comment 12

[Eric Shepherd [:sheppy]]

That this is enabled by default in 53 is now noted in Firefox 53 for developers, and is mentioned on all the pages documenting DTMF that have been created for bug 1012645.