1012668 - Use escaped backslash \\ in setup-manual-activesync-username

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Francesco Lodolo [:flod]]

Bug 993422 added this string
https://github.com/mozilla-b2g/gaia/pull/18082/files

> setup-manual-activesync-username.placeholder=Domain\Username

Problem is that tools don't know how to digest this string, expecting \U to be part of a Unicode character (e.g. \U0020).

We should use \\ instead of \, the result is the same on Gaia. Per discussion on IRC with :pike, no need for a new string ID in this case, since the existing localization is still perfectly good.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8424816 [details] [review]
Pull request on Github

Got f+ offline from :pike and :stas, asking for real reviewer.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8424816 [details] [review]
Pull request on Github

Did you mean to change the capitalization of the key?

-setup-manual-activesync-username.placeholder=Domain\Username
+setup-manual-ActiveSync-username.placeholder=Domain\\Username

That seems incorrect.

Comment 4

[Francesco Lodolo [:flod]]

(In reply to Andrew Sutherland (:asuth) from comment #3)
> Did you mean to change the capitalization of the key?

Absolutely no, wondering how that happened :-\

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 8424816 [details] [review]
Pull request on Github

I can't understand where the ActiveSync part came from, even the bug subject was correct from copy and paste.

Sorry for the extra noise, and thanks for spotting my error.

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Great, thanks for all your help with issues like these! r=asuth

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/19382
https://github.com/mozilla-b2g/gaia/commit/688cf58ecd6bfece1baa34df86bce691a216e7d3