1012677 - Investigate delayed initialization of nsILoginManager in Firefox for Android

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Data Providers, defect)

Description

[:Paolo Amadini]

Some automated tests show that early initialization of the Login Manager service (nsILoginManager) in Firefox for Android is still required by the Java code that accesses the logins database.

However, it might be possible to introduce lazy initialization like bug 856470 has done for Desktop. In fact it's not clear if this requirement is caused by the Data Providers themselves or by the Java tests that use them.

Comment 1

[:Paolo Amadini]

This line should be moved inside a setTimeout call:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#402

This should not affect the browser, however it causes some Java test failures.

Comment 2

[Lawrence Mandel [:lmandel] (use needinfo)]

Tracking for 32 as Paolo expects that this bug will fix bug 1018463.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: change-loginmanager-delay v0.1

I decided to use the delayed-startup system for this and not use a setTimeout. I moved the SafeBrowsing init in here too, since it was in it's owe 5 second setTimeout to avoid startup performance issues.

I also queued these on the main thread to allow them to not create a large blocking call.

Try run here, but we'll need to look at autophone specifically:
https://tbpl.mozilla.org/?tree=Try&rev=a49f3c0ca2fa

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/e21dd0c363f8

If autophone doesn't see any change, or maybe even sees a regression, I can add the setTimeout.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8465722 [details] [diff] [review]
change-loginmanager-delay v0.1

Approval Request Comment
[Feature/regressing bug #]:bug 1018463
[User impact if declined]: Performance regression
[Describe test coverage new/current, TBPL]:Just landed and we need to wait for an autophone test run
[Risks and why]: Low, just mocving code to a different place in startup.
[String/UUID change made/needed]: none

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e21dd0c363f8

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/352420f664bf
https://hg.mozilla.org/releases/mozilla-beta/rev/c110771b033f