Closed Bug 1013036 Opened 10 years ago Closed 10 years ago

[Stingray] Static elements on homescreen

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: lchang, Assigned: lchang)

References

Details

(Whiteboard: [FT:Stream3])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
johnhu
: review+
GaryChen
: review+
dwi2
: review+
Details | Review
There are some static elements (non-widget) on homescreen like TV video, bookmarks, etc. We may put them on correct position based on Layout Editor (bug 1002339).
Assignee: nobody → lchang
Attached file Pull Request 19459
Hi Guys, Could you please help to review this? Thanks.
Attachment #8426059 - Flags: review?(tzhuang)
Attachment #8426059 - Flags: review?(johu)
Attachment #8426059 - Flags: review?(gchen)
Comment on attachment 8426059 [details] [review]
Pull Request 19459

Looks good to me.
Attachment #8426059 - Flags: review?(johu) → review+
Comment on attachment 8426059 [details] [review]
Pull Request 19459

Looks good for me, r=gchen.
Thanks.
Attachment #8426059 - Flags: review?(gchen) → review+
Comment on attachment 8426059 [details] [review]
Pull Request 19459

looks good to me, thanks
Attachment #8426059 - Flags: review?(tzhuang) → review+
travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/25761750

merged in gaia master branch:
https://github.com/mozilla-b2g/gaia/commit/da4c2e0a13ac0e120bcb0fc4ff822fe9ac0c440c

John, Gary and Tzu-Lin, Thanks a lot!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [FT:Stream3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: