Closed
Bug 1002339
Opened 10 years ago
Closed 10 years ago
[Stingray] layout editor for stingray
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: johnhu, Assigned: johnhu)
References
Details
(Whiteboard: [FT:Stream3])
Attachments
(1 file)
We need to calculate the position of widget slots for customizing widget position. In TV, we have only fixed slots and no widgets can cross two slots. Ref: https://wiki.mozilla.org/FirefoxOS/Stingray/Hybrid_Widget_Approach
Assignee | ||
Updated•10 years ago
|
Summary: [Stringray] layout editor for stingray → [Stingray] layout editor for stingray
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → johu
Assignee | ||
Comment 1•10 years ago
|
||
The layout editor is created and its unit tests are also created. Waiting for travis before setting review flag.
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8417248 [details] [review] patch for this bug Please review this patch.
Attachment #8417248 -
Flags: review?(lchang)
Attachment #8417248 -
Flags: review?(ehung)
Assignee | ||
Comment 3•10 years ago
|
||
I had disabled the unit tests, rename test as _test_disabled, because of bug 1006357.
Assignee | ||
Comment 4•10 years ago
|
||
Dear Luke, I had updated the PR to address all of your concerns.
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8417248 [details] [review] patch for this bug Hi all, I had updated the patch to address all luke's concerns. Please review it again. Thanks.
Attachment #8417248 -
Flags: review?(gchen)
Comment 6•10 years ago
|
||
Comment on attachment 8417248 [details] [review] patch for this bug r=me, nice work.
Attachment #8417248 -
Flags: review?(gchen) → review+
Comment 7•10 years ago
|
||
Comment on attachment 8417248 [details] [review] patch for this bug Let's land it! ^^
Attachment #8417248 -
Flags: review?(lchang) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8417248 [details] [review] patch for this bug start to land the code since we got two r+.
Attachment #8417248 -
Flags: review?(ehung)
Assignee | ||
Comment 9•10 years ago
|
||
merged to master: https://github.com/mozilla-b2g/gaia/commit/7f23fa866bec0c9d0540f5089d66bfb59a76011b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Whiteboard: [FT:Stream3]
You need to log in
before you can comment on or make changes to this bug.
Description
•