Closed Bug 1002339 Opened 6 years ago Closed 6 years ago

[Stingray] layout editor for stingray

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: johnhu, Assigned: johnhu)

References

Details

(Whiteboard: [FT:Stream3])

Attachments

(1 file)

We need to calculate the position of widget slots for customizing widget position. In TV, we have only fixed slots and no widgets can cross two slots.

Ref: https://wiki.mozilla.org/FirefoxOS/Stingray/Hybrid_Widget_Approach
Summary: [Stringray] layout editor for stingray → [Stingray] layout editor for stingray
Blocks: 1002337
No longer blocks: 1002336
Assignee: nobody → johu
Attached file patch for this bug
The layout editor is created and its unit tests are also created. Waiting for travis before setting review flag.
Comment on attachment 8417248 [details] [review]
patch for this bug

Please review this patch.
Attachment #8417248 - Flags: review?(lchang)
Attachment #8417248 - Flags: review?(ehung)
I had disabled the unit tests, rename test as _test_disabled, because of bug 1006357.
Dear Luke,

I had updated the PR to address all of your concerns.
Depends on: 1006357
No longer depends on: 1006357
Comment on attachment 8417248 [details] [review]
patch for this bug

Hi all,

I had updated the patch to address all luke's concerns. Please review it again. Thanks.
Attachment #8417248 - Flags: review?(gchen)
Comment on attachment 8417248 [details] [review]
patch for this bug

r=me, nice work.
Attachment #8417248 - Flags: review?(gchen) → review+
Comment on attachment 8417248 [details] [review]
patch for this bug

Let's land it! ^^
Attachment #8417248 - Flags: review?(lchang) → review+
Comment on attachment 8417248 [details] [review]
patch for this bug

start to land the code since we got two r+.
Attachment #8417248 - Flags: review?(ehung)
merged to master: https://github.com/mozilla-b2g/gaia/commit/7f23fa866bec0c9d0540f5089d66bfb59a76011b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [FT:Stream3]
You need to log in before you can comment on or make changes to this bug.