Closed
Bug 1013930
Opened 11 years ago
Closed 11 years ago
The StorageActor should make use of the TabActor's windows list and events
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1060925
People
(Reporter: pbro, Unassigned)
References
Details
Some of the patches checked-in in bug 977043 equipped the TabActor with events one can listen to know when a windows are created.
Bug 1007021 builds on this to add events emitted when windows are destroyed and to give a simple way to list windows in the current tab.
Based on this, the StorageActor could probably be re-worked a little bit to avoid having to do its own windows management as it currently does by maintaining `this.childWindowPool`.
| Reporter | ||
Comment 1•11 years ago
|
||
A note from :ochameau in bug 1007021:
> I'm wondering if storage.js code is working as expected over here:
> http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/
> storage.js#277
> let host = this.getHostName(window.location);
> If I'm following :bz comment correctly, window.location may be bogus
> (it can end up being already set to a value for the next document or throw?).
> Could you take a look at window.location in window-destroyed of your patch
> and see if that's returns something correct without throwing?
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•