1060925 - Switch to window-ready|destroyed events of the BrowsingContextTargetActor

Status: RESOLVED INVALID

(DevTools :: Storage Inspector, defect, P3)

Comment 1

[Girish Sharma [:Optimizer]]

This bug will just switch to the common events. Bug 1060925 will take care of properly firing the events. Combination of this and that will make frame selection automagically work.

Comment 3

[Alexandre Poirot [:ochameau]]

See bug 1013930 comment 1. There may be something wrong with existing code.

Comment 4

[Alexandre Poirot [:ochameau]]

Also doing this would also allow you to stop using `browser` reference and would make the actor work on b2g!

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Filter on 1ff0543e-b501-4893-a72b-e4773c01e655

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

A correction to comment 1. Bug 1061509 will take care of properly firing the events. A combination of this and that will make frame selection automagically work.

Comment 7

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 8

[Chris Peterson [:cpeterson]]

not a Fission bug

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Alex, is this still relevant?

Honza

Comment 10

[Alexandre Poirot [:ochameau]]

Well, yes, this bug is about making the storage panel work with the iframe drop down menu.
This should still be broken as I'm not aware of any work being done around window-ready/destroyed events in storage.

Having said that, we would probably revisit the implementation of the iframe dropdown someday and ultimately get rid of these window-ready/destroy evens in favor of one brand new WindowGlobalTargetActor for each new navigation no matter if it is top level of iframe document.
But there is no concrete plan yet to do that. It could be a M3 cleanup task.

Comment 11

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the explanation Alex.

Honza

Comment 12

[Neha Kochar [:neha]]

Honza said this is not part of dt-fission-m3-mvp and is not considered Fission M7 blocker.

Comment 13

[Chris Peterson [:cpeterson]]

Moving "dt-fission-m3-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.

Comment 14

[Alexandre Poirot [:ochameau]]

This no longer make sense now that we moved to storage resources.