Closed
Bug 1014318
Opened 11 years ago
Closed 9 years ago
Use properties to handle chunking
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: catlee, Unassigned)
References
Details
(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/3039] )
Attachments
(2 files)
|
1.18 KB,
patch
|
mozilla
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
|
49.06 KB,
patch
|
mozilla
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
If we can use properties to handle chunking, we'll get rid of several thousand builders.
First I'm going to refactor generateTalosBranchObjects to make it easier to implement my changes.
|
Reporter | |
Comment 1•11 years ago
|
||
the current code actually changes the object branch_config refers to for subsequent passes though the code. this breaks my refactoring, since branch_objects now lives inside a different function.
I think it's more correct to modify branch_config to force the symbol downloading settings to be what we want.
Attachment #8426687 -
Flags: review?(nthomas)
|
|
Reporter | |
Comment 2•11 years ago
|
||
removing some unused code
Attachment #8426688 -
Flags: review?(nthomas)
|
||
Updated•11 years ago
|
Attachment #8426687 -
Flags: review?(nthomas) → review+
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8426688 [details] [diff] [review]
cleanup
Yeah, looks like we only have mobile (is_remote) chunked buildbot-factory-based unittests.
Attachment #8426688 -
Flags: review?(nthomas) → review+
|
|
Reporter | |
Updated•11 years ago
|
Attachment #8426687 -
Flags: checked-in+
|
|
Reporter | |
Updated•11 years ago
|
Attachment #8426688 -
Flags: checked-in+
|
||
Comment 4•11 years ago
|
||
Merged and deployed to production.
|
|
Reporter | |
Updated•11 years ago
|
Assignee: catlee → nobody
|
||
Updated•11 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/3030]
|
|
||
Updated•11 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/3030] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/3035]
|
|
||
Updated•11 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/3035] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/3039]
|
|
Reporter | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INCOMPLETE
|
Assignee | |
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•