1014462 - [NFC] nfcd returns NFC_DISCONNECT_ERROR while trying to connect to a fake tag

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Krzysztof Mioduszewski[:tauzen]]

Please consider the following marionette test scenario:
1. Toggle NFC On
2. Enable RE0
3. Register and fire onpeerready
4. Create mozNFCTag using sessionToken received in onpeerready callback
5. Call mozNFCTag.connect('NDEF')

This results in an error, as expected. But the error code which nfcd is sending is NFC_DISCONNECT_ERROR [1]. I would expect to get here NFC_CONNECT_ERROR as we are trying to connect to a tag. 

This test is part of error message testing in Bug 933595. 

[1] https://github.com/mozilla-b2g/platform_system_nfcd/blob/master/src/NfcService.cpp#L383

Comment 1

[Krzysztof Mioduszewski[:tauzen]]

Attachment: pull-request-1014462.txt

Comment 2

[Dimi Lee [:dimi]]

I use ERROR_DISCONNECT because Android return ERROR_DISCONNECT when tag connect fail.
But i do agree return NFC_ERROR_CONNECT is easier to understand.

Yoshi, do you have any suggestion?

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8426926 [details]
pull-request-1014462.txt

okay to me

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://github.com/mozilla-b2g/platform_system_nfcd/commit/1997f7f20aebbe95fb10111465c0db945bd041fe