1014910 - Add Web Lit badge icons to competency subpages

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Cassie McDaniel [:cassiemc]]

The font-awesome icons Jess is using for the Web Lit badges should be on each of the sub-pages for the Web Lit competencies (similar to the check icon in the header of the credibility mockup, see here: https://projects.invisionapp.com/d/main#/console/1022755/22856977/preview )

Ali, would it be helpful if Jess provided a list of the icons used? What info would you need, like the link to the icon or the code itself? If you provide the format, maybe Jess could list those for us here once completed.

Also, it appears there are only 12 'graphic design' bugs for the may30 deadline on https://wiki.mozilla.org/Webmaker. Matt, are we missing 3?

Comment 1

[Ali Al Dallal [:alicoding]]

I can't access the link provided there @cassie

Sorry, you aren't a collaborator on the project you tried to access. Please inform the project owner. [ID: 1398794]

Comment 2

[Matt Thompson (@OpenMatt :OpenMatt)]

> it appears there are only 12 'graphic design' bugs for the may30
> deadline on https://wiki.mozilla.org/Webmaker. Matt, are we missing 3?

I believe Jess and I fixed this on Friday. There are currently 15 tickets tagged "[weblitbadges][may30]"
(16 + 1 dupe)
https://wiki.mozilla.org/Webmaker/Badges#.5BMay30.5D

Comment 3

[Ali Al Dallal [:alicoding]]

There are 3 still not completed but the rest I have added the icon.

Navigation: https://dl.dropboxusercontent.com/spa/n5v3bx9nnjkdpzf/ve58dn5i.png
Search: https://dl.dropboxusercontent.com/spa/n5v3bx9nnjkdpzf/j0s3ze1w.png
Security: https://dl.dropboxusercontent.com/spa/n5v3bx9nnjkdpzf/o75r62ej.png
Remixing: https://dl.dropboxusercontent.com/spa/n5v3bx9nnjkdpzf/xob9dnfs.png
Coding/Scripting: https://dl.dropboxusercontent.com/spa/n5v3bx9nnjkdpzf/ys-k_tg8.png
Sharing: https://dl.dropboxusercontent.com/spa/n5v3bx9nnjkdpzf/0v8pa3z8.png
Community Participation: NONE
Open Practices: NONE
Web Mechanics: https://dl.dropboxusercontent.com/spa/n5v3bx9nnjkdpzf/buseno7l.png
Credibility: https://dl.dropboxusercontent.com/spa/n5v3bx9nnjkdpzf/0-7eayjz.png
Composing for the Web: https://dl.dropboxusercontent.com/spa/n5v3bx9nnjkdpzf/y5a5fzzn.png
Design and Accessibility: https://dl.dropboxusercontent.com/spa/n5v3bx9nnjkdpzf/2jr54vwh.png
Infrastructure: https://dl.dropboxusercontent.com/spa/n5v3bx9nnjkdpzf/rycr8o0o.png
Collaborating: NONE
Privacy: https://dl.dropboxusercontent.com/spa/n5v3bx9nnjkdpzf/_79e1j5d.png

Comment 4

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/webmaker.org/pull/748

Comment 5

[Cassie McDaniel [:cassiemc]]

Ali, let's design review these today in person, ok?

Comment 6

[Aki Rose Braun [:akirose]]

What about `fa-users` for Community Participation AND Collaborating?

Comment 7

[Aki Rose Braun [:akirose]]

Comment on attachment 8428950 [details] [review]
https://github.com/mozilla/webmaker.org/pull/748

I've actually added some fa mixins so we don't have to add more cruft (empty spans and i tags) to the markup, but I'm not going to nitpick for this PR since that shim just got merged today. Perhaps something to contemplate when we iterate though?

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/e204c4c2e423d1447d162e0016c6c6f63d46ed30
Bug 1014910 - Add Web Lit badge icons to competency subpages