1015029 - 8x10 OMX H.264 encoder doesn't support Constant bitrate config

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

The 8x10 H.264 OMX encoder doesn't support OMX_Video_ControlRateConstant and you get Variable bitrate if you try to use it.  The only viable candidate is OMX_Video_ControlRateConstantSkipFrames, which is CBR with frame-skipping after an IDR to keep the bitrate average ok.

This requires reworking the encode queue logic to account for the frame skipping.  There is also a bug in the encoder or stagefright where the input timestamps don't appear in the output, so the code using timestamps is ifdef'd off.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Use OMX_VIDEO_ControlRateConstantSkipFrames mode for H.264 OMX encoder

Comment 2

[John Lin [:jhlin][:jolin]]

Comment on attachment 8427515 [details] [diff] [review]
Use OMX_VIDEO_ControlRateConstantSkipFrames mode for H.264 OMX encoder

Review of attachment 8427515 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/media-conduit/WebrtcOMXH264VideoCodec.cpp
@@ +579,5 @@
>        CODEC_LOGD("OMX: (encode no output available this time)");
>        return false;
>      }
>  
> +    uint32_t target_timestamp = (timeUs * 90ll) / 1000; // us -> 90KHz

s/target_timestamp/targetTimestamp/g

@@ +596,5 @@
>        webrtc::EncodedImage encoded(output.Elements(), output.Length(),
>                                     output.Capacity());
>        encoded._frameType = (isParamSets || isIFrame) ?
>                             webrtc::kKeyFrame : webrtc::kDeltaFrame;
> +      EncodedFrame input_frame;

s/input_frame/inputFrame/g

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Green try on the mass of patches -
https://tbpl.mozilla.org/?tree=Try&rev=36fed02b8193

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c852c4ecde1

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8c852c4ecde1