1015157 - [UX] Quick visual fixes for lightweight theme display on Windows and Linux

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: Windows 8.png

Since we want to promote lightweight themes more aggressively, we should fix some of the visual glitches they currently have on Windows and Linux in windowed mode.

We can't draw inside the window border directly (yet), so we'll need to design our way around this limitation.

Comment 1

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: Windows 7.png

Comment 2

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: Windows XP.png

Comment 3

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: Linux.png

Comment 4

[Zhenshuo Fang (:fang) - Firefox UX Team]

Attachment: BorderWin7.jpg

Comment 5

[Zhenshuo Fang (:fang) - Firefox UX Team]

Attachment: Border_Win8.jpg

Comment 6

[Zhenshuo Fang (:fang) - Firefox UX Team]

To summarize the issues & solution:

1. Undefined border on both side of the tab area on Win 8 & Win 7.
We should add a transparent 1px grey border on both side of the theme (on the tab area), the color value is the same as the border between the current tab & the background. See attachment attachment 8456462 [details] and attachment 8456464 [details] above.

2. On Windows 8, the theme is one pixel off to the left, I'm not sure whether we can draw inside the window frame but if we can, we should move the theme to the right for 1px. There is also one weird pixel in the close button that we should get rid of, see attachment 8427715 [details] (if you look really close, there is a weird blue pixel inside the red close button)

3. On Windows 7, we don't have to have the 1px border since there's a blue window frame, but we should give the theme a rounded corner to match the window itself.

I think issue #1 is a blocker for shipping this, and the rest are "nice to have". Also after some discussion we think we are pretty ok on Linux.

Comment 7

[Zhenshuo Fang (:fang) - Firefox UX Team]

Implementation bug: Bug 1038990 - Implement quick visual fixes for lightweight theme display on Windows

Comment 8

[Christian Ascheberg]

(In reply to Zhenshuo Fang (:fang) - Firefox UX Team from comment #6)
> 2. On Windows 8, the theme is one pixel off to the left, I'm not sure
> whether we can draw inside the window frame but if we can, we should move
> the theme to the right for 1px. There is also one weird pixel in the close
> button that we should get rid of, see attachment 8427715 [details] (if you
> look really close, there is a weird blue pixel inside the red close button)

There is more to fix, see bug 929986.