1015249 - [Purchased Media] Update to use gaia-header

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Comment 1

[David Flanagan [:djf]]

The "purchased media" app is gaia/apps/fl/

There are changes pending to it in 971618, that might affect the headers works. You might want to wait until that bug lands before updating the headers.

The app was never carefully designed by UX, so this might be a funky one to fix up.

Comment 2

[Wilson Page [:wilsonpage]]

(In reply to David Flanagan [:djf] from comment #1)
> The "purchased media" app is gaia/apps/fl/
> 
> There are changes pending to it in 971618, that might affect the headers
> works. You might want to wait until that bug lands before updating the
> headers.
> 
> The app was never carefully designed by UX, so this might be a funky one to
> fix up.

Thanks. Can you tell me what the 'purchased media' app is, and how I can launch it?

Comment 3

[Wilson Page [:wilsonpage]]

"To launch the FL app, visit djf.net/t.html, click on "A TCL test suite",
and then click on any of the links on that page. That should open the app."

Comment 4

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 5

[Wilson Page [:wilsonpage]]

The patch is based on top of bug 1046791 which needs to land first.

Comment 6

[David Flanagan [:djf]]

Wilson,

Why did you change the back button from shown by default to hidden by default? Is that a required part of this patch or just an unrelated improvement to avoid a flash of a back button that shows up and then disappears?

Comment 7

[Wilson Page [:wilsonpage]]

(In reply to David Flanagan [:djf] from comment #6)
> Wilson,
> 
> Why did you change the back button from shown by default to hidden by
> default? Is that a required part of this patch or just an unrelated
> improvement to avoid a flash of a back button that shows up and then
> disappears?

Correct. JavaScript is not being run until 'load' so the user sees a flash of a 'back' button before it is hidden. It seemed to work better to hide and reveal when needed.

Comment 8

[David Flanagan [:djf]]

Comment on attachment 8465578 [details] [review]
pull-request (master)

This looks good to me. The Wallpaper and Ringtones apps use the X icon instead of the < icon to cancel the pick activity, and it might be worth fixing that in the FL app now so that it matches those other apps.

Comment 9

[Wilson Page [:wilsonpage]]

Landed on 'master'

https://github.com/mozilla-b2g/gaia/commit/d85bbae28dd9ab9679b42d8d37c84810059e097c