1015292 - [Calendar] Update to use gaia-header

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Comment 1

[Yan Or]

Attachment: PR

Comment 2

[Yan Or]

Comment on attachment 8473413 [details] [review]
PR

Rebased to latest master and fixed several bugs.

Still looking into a TBPL crash that may not be related but I think we can start the review process.

Comment 3

[Stephany Wilkes]

Marking this bug for 2.1 since the web components Header is the one committed web component for 2.1. Other web components for 2.2 depend on Header going first. 

Sorry for doing this late; Hema just brought this bug to my attention today, but it reflects agreed scope and is in the agreed 2.1 plan. Just updating the flags appropriately for release tracking.

Comment 4

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8473413 [details] [review]
PR

it's looking good, just a few comments on github. please flag me again after you update the patch. cheers.

Comment 5

[Yan Or]

Comment on attachment 8473413 [details] [review]
PR

Update patch based on feedback.

Visual issues will be fixed in the next update of gaia-header.

Comment 6

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8473413 [details] [review]
PR

LGTM! good work.

Comment 7

[Stephany Wilkes]

Is this cleared to land? Just checking. :)

Comment 8

[Yan Or]

I think so.  Bug 1055004 seems to occur beyond the gaia-header patches.

Comment 9

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Carrying over r+

Comment 10

[Wilson Page [:wilsonpage]]

Comment on attachment 8479047 [details] [review]
pull-request (master)

LANDED https://github.com/mozilla-b2g/gaia/commit/85cd1af363fc0dc3d38adff6ef3e1c6425dc6583