Closed Bug 1015320 Opened 8 years ago Closed 8 years ago

Modify AOL Repack Configuration

Categories

(Release Engineering :: Release Requests, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: brian.ellis, Assigned: mconnor)

References

Details

Attachments

(3 files)

Export file containing patch for AOL, AOL DE and AOL UK partner repacks for Firefox 30
Component: General → Releases
Product: Firefox → Release Engineering
Target Milestone: Firefox 30 → ---
Assignee: nobody → mconnor
mconnor, still time to vet and land these changes before Firefox 30.0 builds kick off ~ Monday afternoon ?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(mconnor)
Comment on attachment 8427867 [details] [diff] [review]
repack_full_changes_for_AOL.diff

Upon investigation, this appears to be the UK toolbar code catching up to the US version.  There are only minor differences to that version (once you ignore all of the aoluk vs. aol instances), so I'm happy to a=me.

Brian, in order to speed up reviews/approvals, please take care to describe the nature of the changes.  In addition, there's now a "Releases: Custom Builds" component you can select to ensure that the right team doesn't miss them.
Attachment #8427867 - Flags: review+
Flags: needinfo?(mconnor)
https://hg.mozilla.org/build/partner-repacks/rev/9ccf975f15a5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Thanks!
Component: Releases → Releases: Custom Builds
Hi - I just checked the partners builds created today and while AOL UK looks ok, AOL and AOL DE still weren't updated.  There were changes to the other two partners.  Specifically the toolbar version number was updated for all three partners (you can see this in the install.rdf) and for AOL DE the url for the eBay button has changed.  So I have reopened this so it can be addressed.

thanks,
Brian Ellis
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
ok - I see my mistake.  I only created a export file for aol_de.  One of these days, I'll figure out hg.  I have attached the exports for aol and aol_de.  The changes are the toolbar version number was updated for both and for aol_de the url for the eBay button was changed.
I saw that the new builds were created today but I don't see any change for AOL or AOL DE.  I reexamined the export files I delivered yesterday and they do have the changes:

From AOL
diff --git a/partners/aol/distribution/extensions/{7affbfae-c4e2-4915-8c0f-00fa3ec610a1}/install.rdf b/partners/aol/distribution/extensions/{7affbfae-c4e2-4915-8c0f-00fa3ec610a1}/install.rdf
--- a/partners/aol/distribution/extensions/{7affbfae-c4e2-4915-8c0f-00fa3ec610a1}/install.rdf
+++ b/partners/aol/distribution/extensions/{7affbfae-c4e2-4915-8c0f-00fa3ec610a1}/install.rdf
@@ -2,27 +2,27 @@
 <RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:em="http://www.mozilla.org/2004/em-rdf#">
   <Description about="urn:mozilla:install-manifest">
   
   <em:creator>AOL Inc.</em:creator>
   <em:description>AOL Toolbar for Firefox</em:description>
   <em:homepageURL>http://toolbar.aol.com/aol/customfirefox</em:homepageURL>
   <em:id>{7affbfae-c4e2-4915-8c0f-00fa3ec610a1}</em:id>
   <em:name>AOL Toolbar</em:name>
-  <em:version>5.74.1.9980</em:version>
+  <em:version>5.74.1.10080</em:version>

From AOL DE
diff --git a/partners/aol_de/distribution/extensions/{43196362-5378-448b-8944-f097fa65e932}/install.rdf b/partners/aol_de/distribution/extensions/{43196362-5378-448b-8944-f097fa65e932}/install.rdf
--- a/partners/aol_de/distribution/extensions/{43196362-5378-448b-8944-f097fa65e932}/install.rdf
+++ b/partners/aol_de/distribution/extensions/{43196362-5378-448b-8944-f097fa65e932}/install.rdf
@@ -2,27 +2,27 @@
 <RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:em="http://www.mozilla.org/2004/em-rdf#">
   <Description about="urn:mozilla:install-manifest">
   
   <em:creator>AOL Inc.</em:creator>
   <em:description>Custom Firefox DE Toolbar for Firefox</em:description>
   <em:homepageURL>http://toolbar.aol.com/aolde/aolde-ff</em:homepageURL>
   <em:id>{43196362-5378-448b-8944-f097fa65e932}</em:id>
   <em:name>Custom Firefox DE Toolbar</em:name>
-  <em:version>5.95.1.9992</em:version>
+  <em:version>5.95.1.10084</em:version>


Can you let me know if the build I looked at this morning is complete?
hwine, we'll need to use https://intranet.mozilla.org/Build:Partners:Repacks:Creation, once the 2nd & 3rd attachments get signoff from mconnor and land in the partner-repacks repo.
Blocks: 996137
https://hg.mozilla.org/build/partner-repacks/rev/9d2395a33703
https://hg.mozilla.org/build/partner-repacks/rev/16ddfaedf3b4

Releng is starting builds ASAP.
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Component: Custom Release Requests → Release Requests
You need to log in before you can comment on or make changes to this bug.