1015535 - Comment nodes shouldn't be considered for translation

Status: VERIFIED FIXED

(Firefox :: Translations, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: Comment nodes shouldn't be considered for translation

Comment nodes are nsGenericDOMDataNodes with textual content, so they were returning true for HasTextForTranslation, but that should be obviously false. (More generally, any non-text node).

This was not causing any problems in the translation itself, and they are already replaced with placeholders in a later step of the process. However, it causes otherwise-empty nodes to be unnecessarily considered for translation. E.g:

<div><!-- Comment --></div>

Which would be sent to the translation service as "<div><br></div>", while it doesn't need to be sent at all.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8428193 [details] [diff] [review]
Comment nodes shouldn't be considered for translation

Hmm, this is a bit too strict.
CDATA nodes are filtered out.
So

CDATA_SECTION_NODE
if (NodeType() != nsIDOMNode::TEXT_NODE && NodeType() != nsIDOMNode::CDATA_SECTION_NOD) {

Comment 2

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/integration/fx-team/rev/a311f34398c2

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Marco, please add this bug to the current iteration

Comment 4

[Marco Mucci [:MarcoM]]

Added to Iteration 32.2

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a311f34398c2