1015664 - Remove NS_HIDDEN usage in Gecko

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Now that all platforms but Mac use #pragma visibility hidden, we can remove most usage of NS_HIDDEN_() and NS_HIDDEN.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 1: Remove usage of NS_HIDDEN_()

This patch was mechanically generated via perl -pi -e 's/NS_HIDDEN_\(([^)]*)\)/$1/g'

I excluded xpcom/glue because AIUI that code might be built outside of libxul without the visibility pragmas.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Remove some NS_HIDDEN usage

This was automatically generated via perl -pi -e 's/ NS_HIDDEN;/;/g'

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Remove NS_HIDDEN_VISIBILITY from NS_IMETHOD_VISIBILITY

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 4: Remove NS_HIDDEN in a few miscellaneous places

Comment 5

[Benjamin Smedberg]

Comment on attachment 8428329 [details] [diff] [review]
Part 1: Remove usage of NS_HIDDEN_()

Please exclude the changes in xpcom/string/public/nsXPCOMStrings.h

Comment 6

[Benjamin Smedberg]

Comment on attachment 8428433 [details] [diff] [review]
Remove some NS_HIDDEN usage

Please exclude the change in xpcom/build/xrecore.h

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/58a202b28197
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e200260a453
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc7786236f98
https://hg.mozilla.org/integration/mozilla-inbound/rev/e09168ca3072

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/58a202b28197
https://hg.mozilla.org/mozilla-central/rev/4e200260a453
https://hg.mozilla.org/mozilla-central/rev/fc7786236f98
https://hg.mozilla.org/mozilla-central/rev/e09168ca3072