Closed
Bug 1020971
Opened 11 years ago
Closed 6 years ago
Remove NS_HIDDEN usage in comm-central?
Categories
(MailNews Core :: Backend, task)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 68.0
People
(Reporter: aceman, Assigned: jorgk-bmo)
References
Details
Attachments
(1 file)
|
8.99 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
Bug 1015664 removed uses of NS_HIDDEN from Gecko.
comm-central also uses a small number of this macro:
http://mxr.mozilla.org/comm-central/search?string=NS_HIDDEN&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
And also redefines IMETHOD_VISIBILITY, what is also removed in https://bug1015664.bugzilla.mozilla.org/attachment.cgi?id=8428434:
http://mxr.mozilla.org/comm-central/search?string=IMETHOD_VISIBILITY&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
How do we determine if we can also remove this in c-c ?
|
||
Comment 1•6 years ago
|
||
How do we determine if we can also remove this in c-c ?
Is this still even a thing?
Type: defect → task
Flags: needinfo?(mkmelin+mozilla)
|
Assignee | |
Comment 2•6 years ago
|
||
Looks like this can all go now.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Flags: needinfo?(mkmelin+mozilla)
Attachment #9064297 -
Flags: review?(mkmelin+mozilla)
Attachment #9064297 -
Flags: review?(acelists)
|
||
Updated•6 years ago
|
Attachment #9064297 -
Flags: review?(mkmelin+mozilla)
Attachment #9064297 -
Flags: review?(acelists)
Attachment #9064297 -
Flags: review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/1596eb55471a
Port bug 1015664: Remove NS_HIDDEN and friends. r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 68.0
You need to log in
before you can comment on or make changes to this bug.
Description
•