Closed Bug 1015763 Opened 11 years ago Closed 10 years ago

tabs/utils getTabForContentWindow() throws with e10s enabled

Categories

(Add-on SDK Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zombie, Assigned: zombie)

References

Details

Attachments

(1 file)

the `browser` in the child process on line 263 in [1] doesn't have an `ownerDocument`. we could probably just iterate over tabs and compare `contentWindow`s, like we already do for Fennec. https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/tabs/utils.js#L263
and i did just that. no new tests, as this is to fix already existing tab tests when running with e10s enabled. Matteo, can you please run the tests on Fennec, as i reduced the two methods into one?
Assignee: nobody → tomica+amo
Status: NEW → ASSIGNED
Attachment #8428769 - Flags: review?(zer0)
Attachment #8428769 - Flags: review?(zer0) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/23a07371d5113721fb221c65a1191845f2d03ef5 bug 1015763 - e10s getTabForContentWindow throws https://github.com/mozilla/addon-sdk/commit/c675ffdcece90e2583f6a96f7c153b9d4a689aa9 Merge pull request #1498 from zombie/1015763-getTabForContentWindow bug 1015763 - getTabForContentWindow throws with e10s, r=@ZER0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: