1015623 - fix sdk/tabs for e10s

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Tomislav Jovanovic :zombie]

this is probably going to be a tracking bug, as problems are turning out to be multifaceted.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I have an addon with the following code set to run in a Nightly profile with e10s set to autostart:
var tabs = require("sdk/tabs");
var timers = require("sdk/timers");

timers.setTimeout(openandattachtab, 5000);

function openandattachtab() {
var mytab = tabs.open({
  url: "https://mozilla.org",
  onReady: function onReady(tab) {
    tab.attach({
      contentScriptFile: "./testtabattach.js"
    });
  }
});
}

And the contentScriptFile contains the following:
console.log("Hello");


When this runs, after the five second timer finishes, I see the tab open to mozilla.org, and then see the following errors in the error console:

Object { , 5 more… } runner.js:190
Object { , 5 more… } Promise-backend.js:869
Exception { message: "Failure arg 0 [nsIScriptSecurityManager.isSystemPrincipal]", result: 2147500037, name: "NS_ERROR_FAILURE", filename: "resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/kwier_000/Documents/GitHub/testprof/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/content/sandbox.js", lineNumber: 122, columnNumber: 0, inner: null, data: null, stack: "WorkerSandbox@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/kwier_000/Documents/GitHub/testprof/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/content/sandbox.js:122:28
constructor@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/heritage.js:145:22
@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/kwier_000/Documents/GitHub/testprof/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/content/worker.js:142:24
dispatch@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/kwier_000/Documents/GitHub/testprof/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/method/core.js:119:11
WorkerConstructor@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/kwier_000/Documents/GitHub/testprof/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/content/worker.js:74:6
constructor@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/heritage.js:145:22
Worker@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/kwier_000/Documents/GitHub/testprof/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/tabs/worker.js:11:15
attach@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/kwier_000/Documents/GitHub/testprof/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/tabs/tab-firefox.js:233:11
onReady@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/kwier_000/Documents/GitHub/testprof/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://jid1-iyle96cenkklww-at-jetpack/teste10stabs/lib/main.js:10:0
_emitOnObject@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/kwier_000/Documents/GitHub/testprof/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/deprecated/events.js:153:8
_emit@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/kwier_000/Documents/GitHub/testprof/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/deprecated/events.js:123:11
TabTrait<._onContentEvent@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/kwier_000/Documents/GitHub/testprof/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/tabs/tab-firefox.js:111:4
", location: XPCWrappedNative_NoHelper } events.js:147



"Hello" never gets logged to the console.


Is there some issue with tab.attach in e10s windows?

Comment 2

[Tomislav Jovanovic :zombie]

(In reply to Wes Kocher (:KWierso) from comment #1)
> Is there some issue with tab.attach in e10s windows?

yes, the loader/sandbox module, and everything that depends on it (ContentWorker, PageMod, tab.attach..) is incompatible with e10s, i'm working on that in bug 1028718..

Comment 3

[Andy McKay]

All the dependencies have been closed, can we close this?