1015817 - [NFC][Contacts] Receiver should get only one record with multiple phone numbers when sender updated contact's phone number and shared via NFC again

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Alison Shiue]

Gaia      f3b5d74dd3428c89cab06db734c62f3c9dbb8c4d
Gecko     https://hg.mozilla.org/mozilla-central/rev/e86a0d92d174
BuildID   20140525160203
Version   32.0a1

Two phone with NFC

STR:
1. Enable NFC on both phones
2. Add a new contact(user1) on phone A
3. Tap 2 phones to share user1
4. Phone A update user1's phone number 
5. Tap 2 phones to share user1 again
6. Check what phone B receive 

Expected result:
phone B should have only one "user1" record with 2 phone numbers

Actual result:
phone B has two "user1" records with different phone number

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Michal,
Please take a look at this one.

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

ni? to Sergi as this is might be related to bug 1015094

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: 2.0+

Comment 4

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

There are some complex rules for the merging algorithm to determine whether 2 contacts are the same one. For example, it uses email to match them, and probably phone number.

When you create contact A, what fields are initially filled?

Cheers.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Alison, can you provide Sergin with the info he is asking in comment 4?

Thanks.

Comment 6

[Alison Shiue]

Hi Sergi,

I created contact A with user name, phone, and email.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Taking the NFC bugs

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

when we do a nfc sharing, we apply merging rules based on passive merging, which means that we are pretty aggressive in the comparison to be sure we are dealing with two contacts that are the same.

Those passive rules says something like:
- If two contacts have same name and surname and both have email or phones, the fields must match to merge them.

Which means, if we have contact A with phone1 in one phone, when importing (no matter if it's NFC, SIM, etc) contact A with phone2 those will be treated as different contacts.

Taking into account those rules, that are defined to make the whole process estable, we can say this is a not valid bug, since according to our rules not having same phone number is a condition to be considered two different contacts.

Closing as worksforme since it's the desired behavior

Cheers,
F.