1015060 - [NFC][Contact] Receiver does not receive the latest contact if the contact has been updated more than twice

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Alison Shiue]

Attachment: S__1064966.jpg

Gaia      7db23414f2d632f4d00b5023ac1090b6045dc5fd
Gecko     https://hg.mozilla.org/mozilla-central/rev/2619a4def1b9
BuildID   20140522160203
Version   32.0a1

Two phone with NFC

STR:
1. Enable NFC on both phones
2. Add a new contact(user1) on phone A
3. Phone A update user1 to user11, and save
4. Phone A update user11 to user111, and save
5. Phone A go to user111 detail view
6. Tap 2 phones together to share user111 
7. Check what phone reveive

Expected result:
Phone should receive user111 

Actual result:
Phone receive user11

(*Note: I tried transfer contact via bluetooth, it worked well.)

Comment 1

[Ken Chang[:kenkai]]

Hi Michal, please check what is happened. Thanks

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

major issue on new feature

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

ni? to Sergi as this is might be related to bug 1015094

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

We have the feeling this bug could be related to bug 1015094, tomorrow we will try to verify.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Moving to this sprint, we need to get ride of blockers!

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Taking the NFC bugs

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to pr 20440

Hi folks,

adding you too for review, not just a nfc bug, but also better to try on it.

Basically when we were saving a contact in the form, we were not passing the changes through the application, so apps that had reference to the old contact they keep it.

@Michal, this will affect your work on the haidficaition, i'm looking forward for having those broadcast messages.

Thanks!

Comment 9

[Michał Budzyński (:michalbe)]

Comment on attachment 8439193 [details] [review]
Pointer to pr 20440

Great Francisco, I love how small but meaningful this patch is. R+, just small nits on GH. 

I'll try to replicate similar behavior in Haida now.

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Thanks Michal, just updated your comments in GH.

Comment 11

[Jose Manuel Cantera]

Comment on attachment 8439193 [details] [review]
Pointer to pr 20440

I left a tiny comment on GH, though

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Jose Manuel Cantera from comment #11)
> Comment on attachment 8439193 [details] [review]
> Pointer to pr 20440
> 
> I left a tiny comment on GH, though

Adding suggested change.

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Landed in master:

https://github.com/arcturus/gaia/commit/1e3f9ff32018d0702ab269851a3c75a1280c633a

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/7047edaa4d3a5cb87a213994cf4bd5e6e826bf5d

Comment 15

[Alison Shiue]

Verified on
Gaia      23e06c3624309db22ad9cb736d89700768b42b36
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/12161a842a8e
BuildID   20140618160200
Version   32.0a2

Comment 16

[Coler]

This issue has been verified successfully on Flame2.1.

Reproducing rate: 0/5
See attachment: Verify_Flame_NFC.mp4

Flame 2.0 build version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141127000203
Version         32.0

Comment 17

[Coler]

(In reply to Coler from comment #16)
> This issue has been verified successfully on Flame2.1.
> 
> Reproducing rate: 0/5
> See attachment: Verify_Flame_NFC.mp4
> 
> Flame 2.0 build version:
> Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
> Gecko-Rev      
> https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
> Build-ID        20141127000203
> Version         32.0

Update the build Version:
Gaia-Rev        5372b675e018b6aac97d95ff5db8d4bd16addb9b
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f34377ae402b
Build-ID        20141127001201
Version         34.0

Comment 18

[Coler]

Attachment: Verify_Flame_NFC.MP4