1016262 - [Settings][Keyboard][V2.0] Pressing the home button cannot save keyboard settings

Status: VERIFIED DUPLICATE of bug 1016219

(Firefox OS Graveyard :: Gaia::Settings, defect)

Comment 1

[William Hsu [:whsu]]

* Description:
  This is a regression bug.
  After checking a keyboard layout then press the home button to leave settings app, the IME list is unchanged.
  Attach the demo video.(WP_20140527_001.mp4)

* Reproduction steps:
  1. Launch the settings app
  2. Go to "Keyboards" -> "Selected Keyboards" -> "Add more keyboards"
  3. Select/check three keyboards
  4. Press home button to leave keyboard settings page
  5. Launch the message app then switch to selected keyboards

* Expected result:
  You can use selected keyboards

* Actual result:
  1. The IME list is unchanged.

* Reproduction build: V2.0 (Buri)
 - Gaia      f3b5d74dd3428c89cab06db734c62f3c9dbb8c4d
 - Gecko     https://hg.mozilla.org/mozilla-central/rev/e86a0d92d174
 - BuildID   20140525160203
 - Version   32.0a1

Comment 2

[William Hsu [:whsu]]

Attachment: WP_20140527_001.mp4

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This is by design unless UX says otherwise. Omega, could you confirm this is a bug or feature?

Comment 4

[Omega Feng [:Omega] [:馮於懋]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #3)
> This is by design unless UX says otherwise. Omega, could you confirm this is
> a bug or feature?

Not sure about the history, but I think each IME should be available as soon as user checks it.
BTW I want to revisit the whole Keyboard settings, maybe targeting to 2.1 and file another bug to track it.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Then I will call this bug not to be not blocking because we have already ship releases with this behavior.

Comment 6

[William Hsu [:whsu]]

This is a regression bug. I cannot reproduce it on V1.4 build.
Arthur has ever fixed related bug on V1.3.
But...some patch seemed to activate it again.
Maybe settings refactor(V2.0) causes this bug.

Comment 7

[William Hsu [:whsu]]

Bug 912020 had a related patch.

Comment 8

[Harvey]

B2G Inbound Regression Window

Last Working
Environmental Variables:
Device: Buri
BuildID: 20140512061704
Gaia: 985ce2a6d1f265bc53b57e3aee7b407da999d57f
Gecko: ef8df83ad337
Version: 32.0a1
Firmware Version: v1.2-device.cfg

First Broken
Environmental Variables:
Device: Buri
BuildID: 20140512063207
Gaia: db341aa99426bfa3b7681d3918295ed5a61ab57d
Gecko: c51120ba4f86
Version: 32.0a1
Firmware Version: v1.2-device.cfg

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 985ce2a6d1f265bc53b57e3aee7b407da999d57f
Gecko: c51120ba4f86

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: db341aa99426bfa3b7681d3918295ed5a61ab57d
Gecko: ef8df83ad337

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/985ce2a6d1f265bc53b57e3aee7b407da999d57f...db341aa99426bfa3b7681d3918295ed5a61ab57d

Comment 9

[Jason Smith [:jsmith]]

Broken by bug 973456.

Arthur - Can you take a look?

Comment 10

[bhavana bajaj [:bajaj]]

BLocking as this is 2.0 regression which we have to fix.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Should we simply dup this to bug 1016219 as there is no patch need here?

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

OK, let's duplicate this bug to bug 1016219.

Comment 13

[William Hsu [:whsu]]

Thanks! Verified this patch.
The bug cannot be reproduced on the latest V2.0 build

* Build Information:
 - Gaia      6aa07ea10420bd77f93d7415b5e34d89acc47a7e
 - Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/c83fdcf0b735
 - BuildID   20140611160205
 - Version   32.0a2