973456 - [settings] refactor Keyboard panel with AMD pattern

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Overview Description:

Refactor Keyboard panel with AMD pattern referring to
https://github.com/crh0716/gaia/tree/settings2_iterative

to make it modularize and more easier to maintain

Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Expected Results:

pass all settings test and act the same as original implementation

Additional Information:

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/18589

WIP

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8411045 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18589

Evelyn, could you help review this patch? It looks huge but most of it is unit test. The remaining parts are panels shared similar structure. Let me know if you need more explanations.

EJ, Fred, George, could you help give some feedbacks? Thanks all!

Comment 3

[[e-mail]]

Comment on attachment 8411045 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18589

Looks good to me, thanks!

Comment 4

[Evelyn Hung]

(In reply to Fred Lin [:gasolin] from comment #3)
> Comment on attachment 8411045 [details]
> Link to https://github.com/mozilla-b2g/gaia/pull/18589
> 
> Looks good to me, thanks!

I'm confused with your feedback-, a wrong flag?

Comment 5

[Evelyn Hung]

Comment on attachment 8411045 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18589

I didn't look too much detail since Fred/EJ has picked a few nits out. Overall looks good to me. Thanks!

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8411045 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18589

Sorry to reply back so late ! It is really a big patch and needs time to take a look. I left some comments on Github and please check it !

Overall it's good to me ! Thanks :P

(Help to fix Fred's wrong flag by the way).

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8411045 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18589

-__- sorry fred, I accidentally remove your f- flag, please put your flag here again !! thanks xD

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks all!

master: db341aa99426bfa3b7681d3918295ed5a61ab57d

Comment 9

[[e-mail]]

Comment on attachment 8411045 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18589

LOL why I lgtm with f-, it's a mystery :-/