1016330 - [css coverage] make it work with B2G

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Paul Rouget [:paul]]

I'll use this bug to tack issues with css coverage and B2G

Comment 1

[Paul Rouget [:paul]]

Some rules are considered as used when they're not. For example: http://i.imgur.com/kFwydII.png
A querySelectorAll of the 2nd rule doesn't return any element in any loaded document.

Comment 2

[Paul Rouget [:paul]]

Kill reference to this._tabActor.browser. This might create issues with sub documents ("load" is sent to browser even for inner documents. It's not the case with tabActor.window).

Comment 3

[Paul Rouget [:paul]]

prettifyCSS needs to be used client side or moved at the toolkit level.

Comment 4

[Joe Walker [:jwalker]]

Move the call to makeRemote to DeveloperToolbar.jsm

Comment 5

[Paul Rouget [:paul]]

http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/csscoverage.js#706

We need to test first there's a cssusage actor. A toolbox might be debugging gecko < 32.

Comment 6

[Paul Rouget [:paul]]

Exception when debugging B2G:

Full message: TypeError: this.conn.allocID is not a function
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
Full stack: Pool<.manage@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:726:7
UsageReportFront<.initialize@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/csscoverage.js:692:5
constructor@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/paul/.mozilla/firefox/tf5iw6v8.dev/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/heritage.js:145:23
exports.getUsage/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/csscoverage.js:765:7
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:863:11
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:742:7

Comment 7

[Joe Walker [:jwalker]]

(In reply to Joe Walker [:jwalker] from comment #4)
> Move the call to makeRemote to DeveloperToolbar.jsm

I'm not doing this here because the toolbar works with multiple targets (i.e the target changes whenever a new tab is shown) and there's a nasty clash of events and promises involved in having the current target be always-remoted.

(Dear Future-Joe: We (by which I mean you) can call target.makeRemote on DeveloperToolbar.show(), and on handleEvent/TabSelect or handleEvent/load, but how do we be sure that keyDown in the input element happens only after that call to makeRemote completes? The obvious answer is a shared promise, but the input element handling is part of GCLI so you need to pass in some sort of a makeRemotePromiseContainer thing to createDisplay(). Ug. Have fun.)

Comment 8

[Joe Walker [:jwalker]]

Attachment: 0001-Bug-1016330-Part-1-Make-CSS-Coverage-work-with-B2G-r.patch

Comment 9

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=6273a8671bc5

Comment 10

[Joe Walker [:jwalker]]

Green try: https://tbpl.mozilla.org/?tree=Try&rev=eded224de172

Landing:
https://tbpl.mozilla.org/?tree=Fx-Team&rev=98c8ea754cb4
https://hg.mozilla.org/integration/fx-team/rev/776897298340

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/776897298340

Comment 12

[Joe Walker [:jwalker]]

(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #2)
> Kill reference to this._tabActor.browser. This might create issues with sub
> documents ("load" is sent to browser even for inner documents. It's not the
> case with tabActor.window).

Bug 1022587

(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #1)
> Some rules are considered as used when they're not. For example:
> http://i.imgur.com/kFwydII.png
> A querySelectorAll of the 2nd rule doesn't return any element in any loaded
> document.

Bug 1016285