1016541 - Thread and Composer. The input placeholder text (Message) should be italic

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Victoria Gerchinhoren [:vicky]]

The input placeholder text (Message) should be italic, the writing text though, should be regular style.
It should have a 1.5 rem gap from the border of the screen
And ideally the text should be a bit more engaging like "write your message here..."

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: 2.0+ as the UI should align with VR design

Comment 2

[bhavana bajaj [:bajaj]]

(In reply to Victoria Gerchinhoren [:vicky] from comment #0)
> The input placeholder text (Message) should be italic, the writing text
> though, should be regular style.
> It should have a 1.5 rem gap from the border of the screen
> And ideally the text should be a bit more engaging like "write your message
> here..."

wesley : all these seem's nice to have's but why would this be a blocker ? If this is not done by FL and uplift would be a right way to go, but this does not sound like a release blocker to me as written.

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

This is the expected design.
https://bug950175.bugzilla.mozilla.org/attachment.cgi?id=8394784

Comment 4

[Julien Wajsberg [:julienw]]

Bhavana, I expect that we can request approval between FL and FC, right? So we don't need this to be a blocker, but we should just request an approval when ready, is that right?

Comment 5

[Victoria Gerchinhoren [:vicky]]

Hi,
The margin on the left hand side of the input field looks OK now, but the placeholder's font still needs to be "italic" style to match the rest of input fields in the OS. This means a very small change, right?

Comment 6

[Maria Angeles Oteo (:oteo)]

Changing the title according to Vicky's last comment.

Comment 7

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 8

[Paco Rampas [:paco]]

Attachment: italic-sms-message.png

Comment 9

[Steve Chung [:steveck]]

Thanks! r=me
in master: bd86b8d68389df7656fc426ea59995d7dfbfa1cb