1016631 - (cosmetic) sysctl()'s 2nd argument is u_int

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Jan Beich]

Attachment: fix

According to OS X and BSDs manpage the 2nd argument is |u_int namelen|. To confuse more, sysctlnametomib()'s last argument is |size_t *namelenp|. int is smaller while size_t is usually larger than u_int on 64bit archs but...
- namelen is not a pointer (to write out of bounds)
- name[] length is constant and fits into u_int (to overflow)

https://developer.apple.com/library/mac/documentation/Darwin/Reference/Manpages/man3/sysctl.3.html

A quick search reveals not many files are affected. Do we still care?

content/media/webrtc/LoadMonitor.cpp (Tier3, my fault)
toolkit/crashreporter/google-breakpad/src/client/ios/Breakpad.mm (NPOTB)
toolkit/crashreporter/google-breakpad/src/client/mac/Framework/Breakpad.mm (NPOTB)
toolkit/crashreporter/google-breakpad/src/client/mac/handler/dynamic_images.cc
xpcom/base/nsDebugImpl.cpp

Comment 1

[Jan Beich]

Comment on attachment 8429607 [details] [diff] [review]
fix

Review of attachment 8429607 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/crashreporter/google-breakpad/src/client/mac/handler/dynamic_images.cc
@@ +562,1 @@
>    int err = sysctlnametomib("sysctl.proc_cputype", mib, &mibLen);

Oh, it was valid use. sysctlnametomib() wants size_t while sysctl() later wants u_int.

Comment 2

[Jan Beich]

Attachment: fix

dropped breakpad changes entirely due to other files being NPOTB

Comment 3

[Jan Beich]

Attachment: fix

Rebased after bug 1013675. Not the other way around because that'd be more prone to introduce typos.

Comment 4

[Jan Beich]

Please, land after bug 1013675.

Comment 5

[Jan Beich]

Attachment: fix + style

s/NULL/nullptr while here per Mozilla code style. Retaining r+ as it's a fix for my code entirely within Tier3 ifdef.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e62fb5c4235

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3e62fb5c4235