Telemetry should indicate whether a debugger is attached

RESOLVED FIXED in mozilla16

Status

()

Toolkit
Telemetry
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: vladan, Unassigned)

Tracking

Trunk
mozilla16
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
This would help prevent red herrings when investigating performance problems and chrome hangs. On Windows, this would be as simple as calling the IsDebuggerPresent method.
(Reporter)

Comment 1

5 years ago
Created attachment 635059 [details] [diff] [review]
Report to Telemetry whether a debugger is attached
Attachment #635059 - Flags: feedback?(taras.mozilla)

Comment 2

5 years ago
Comment on attachment 635059 [details] [diff] [review]
Report to Telemetry whether a debugger is attached

>+      gWasDebuggerPresent = debugService.isDebuggerPresent;

s/DebuggerPresent/DebuggerAttached/ everywhere in the patch sounds nicer to me.

>+
>+  if (sysctl(mib, mibSize, &info, &infoSize, NULL, 0)) {
>+    return NS_ERROR_FAILURE;

Don't do this, return NS_OK & false. This will cause telemetry to fail since there is no try/catch there. Afaik OSX stuff like this is implemented as IPC internally and will occasionally fail.
Attachment #635059 - Flags: feedback?(taras.mozilla) → feedback+
(Reporter)

Comment 3

5 years ago
Created attachment 635110 [details] [diff] [review]
Report to Telemetry whether a debugger is attached

Applied Taras's comments
Attachment #635059 - Attachment is obsolete: true
Attachment #635110 - Flags: review?(benjamin)
Comment on attachment 635110 [details] [diff] [review]
Report to Telemetry whether a debugger is attached

requesting review from smichaud for the mac impl of nsDebugImpl::GetIsDebuggerAttached.
Attachment #635110 - Flags: review?(smichaud)
Attachment #635110 - Flags: review?(benjamin)
Attachment #635110 - Flags: review+
Comment on attachment 635110 [details] [diff] [review]
Report to Telemetry whether a debugger is attached

Looks fine to me.
Attachment #635110 - Flags: review?(smichaud) → review+
(Reporter)

Comment 6

5 years ago
Comment on attachment 635110 [details] [diff] [review]
Report to Telemetry whether a debugger is attached

https://hg.mozilla.org/integration/mozilla-inbound/rev/23d9d354236e
Attachment #635110 - Flags: checkin+

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/23d9d354236e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16

Updated

3 years ago
Depends on: 1016631
You need to log in before you can comment on or make changes to this bug.