763138 - Telemetry should indicate whether a debugger is attached

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Vladan Djeric (:vladan)]

This would help prevent red herrings when investigating performance problems and chrome hangs. On Windows, this would be as simple as calling the IsDebuggerPresent method.

Comment 1

[Vladan Djeric (:vladan)]

Attachment: Report to Telemetry whether a debugger is attached

Comment 2

[(dormant account)]

Comment on attachment 635059 [details] [diff] [review]
Report to Telemetry whether a debugger is attached

>+      gWasDebuggerPresent = debugService.isDebuggerPresent;

s/DebuggerPresent/DebuggerAttached/ everywhere in the patch sounds nicer to me.

>+
>+  if (sysctl(mib, mibSize, &info, &infoSize, NULL, 0)) {
>+    return NS_ERROR_FAILURE;

Don't do this, return NS_OK & false. This will cause telemetry to fail since there is no try/catch there. Afaik OSX stuff like this is implemented as IPC internally and will occasionally fail.

Comment 3

[Vladan Djeric (:vladan)]

Attachment: Report to Telemetry whether a debugger is attached

Applied Taras's comments

Comment 4

[Benjamin Smedberg]

Comment on attachment 635110 [details] [diff] [review]
Report to Telemetry whether a debugger is attached

requesting review from smichaud for the mac impl of nsDebugImpl::GetIsDebuggerAttached.

Comment 5

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 635110 [details] [diff] [review]
Report to Telemetry whether a debugger is attached

Looks fine to me.

Comment 6

[Vladan Djeric (:vladan)]

Comment on attachment 635110 [details] [diff] [review]
Report to Telemetry whether a debugger is attached

https://hg.mozilla.org/integration/mozilla-inbound/rev/23d9d354236e

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/23d9d354236e