Closed Bug 1016824 Opened 10 years ago Closed 10 years ago

Czech layout should be Qwertz

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Type:
defect

Tracking

(blocking-b2g:2.1+, b2g-v2.0 affected, b2g-v2.1 verified, b2g-v2.2 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S6 (10oct)
Project Flags:
blocking-b2g 2.1+
Tracking Flags:
Tracking Status
b2g-v2.0 --- affected
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: sync-1, Assigned: rudyl)

References

Details

(Whiteboard: [p=1])

Attachments

(2 files)

cs_layout.png
40.51 KB, image/png
Details
Patch V1
46 bytes, text/x-github-pull-request
timdream
: review+
bajaj
: approval-gaia-v2.1+
Details | Review 
Firefox OS v1.3
 Mozilla build ID:20140422024003
 
 
 Description: 
 wrong layout selection for Czech sw language there is croatia language selected for writing of messages and another issue is when CZ layout is selected then keybort layout is QWERTY instead of correct one QWERTZ. 
 
 
 Customer Impact Statement: 
 it is very incovenient for customers to use sms
blocking-b2g: --- → 1.3?
Hi Xiuping -

Could you provide a screenshots?
blocking-b2g: 1.3? → ---
Flags: needinfo?(longxiuping)
Attached image cs_layout.png — 
Flags: needinfo?(longxiuping)

    
    

    
  
Hi Delphine, could you help to find someone to check if the keyboard layout of Czech is correct?

Thanks

Vance
Flags: needinfo?(lebedel.delphine)

    
    

    
  
Hi Vance. Sure. 
:Ni Pavel for this!
thanks
Flags: needinfo?(lebedel.delphine) → needinfo?(pcvrcek)

    
    

    
  
My old Android device (2.3) has QWERTY keyboard by default, new Android (some old Samsung Galaxy) has QWERTZ. Not sure what standard is for mobile devices but maybe QWERTZ is better. Michal, what do you think?

> wrong layout selection for Czech sw language there is croatia language selected for writing of messages

I cannot reproduce it. I used Peak device with latest 1.3 from http://downloads.geeksphone.com/ (images-peak-v1.3-2014-05-12.Gecko-95e1b96.Gaia-f71e255.zip). I choosed Czech language and I don't see problem. Maybe I need better description what is wrong and how I can reproduce it because I can write in czech and suggestions are correct for Czech (cs) too. Maybe some build issue?
Flags: needinfo?(pcvrcek) → needinfo?(michal.stanke)

    
    

    
  
I've tested on GP Keon with latest 1.4 (clean installed) and I have QWERTY here.

I agree, that old Android devices had QWERTY in Czech, but for me QWERTZ is "more standard" for default Czech keyboard layout. I think QWERTZ is also default for Windows and Linux distros until you explicitly set QWERTY.
Flags: needinfo?(michal.stanke)

    
    

    
  
I've borrowed Android 4.0 device and it has QWERTZ for Czech as default.

    
    

    
  
Following up here as Czech is a required locale for 2.1
Have you decided for the QWERTZ vs QWERTY layout?
Flags: needinfo?(pcvrcek)

    
    

    
  
QWERTZ is better.
Flags: needinfo?(pcvrcek)

    
    

    
  
[Blocking Requested - why for this release]:

Ok we need to block on this then. Czech is a shipping locale for 2.1
blocking-b2g: --- → 2.1?

    
    

    
  
Triage group reviewed: If 2.1 is shipping to Czech speaking markets, it would block per "broken new feature". If that's the case, renominate.

Otherwise, just fix it and ask for approval to uplift on the patch.

Blocking criteria at https://wiki.mozilla.org/B2G/Triage#Blocker_Triage_Guidelines.
blocking-b2g: 2.1? → ---

    
    

    
  
[Blocking Requested - why for this release]:

Yes, Czech is under the 2.1 Tako critical blocking locales. Renominating
blocking-b2g: --- → 2.1?

    
    

    
  
Triage: blocking per comment above. I hope this can be caught earlier ....

Rudy will fix this. Thank you Rudy!
Assignee: nobody → rlu
Status: NEW → ASSIGNED
blocking-b2g: 2.1? → 2.1+
Summary: [Sora]wrong layout selection → Czech layout should be Qwertz

    
    

    
  

      
      
      
      

        Attached file
          
        Patch V1
        — 
      

    


  
Change the layout from Qwerty to Qwertz as recommended by this bug.

Tim, could you please review this change?
Thank you.

        Attachment #8502386 -
        Flags: review?(timdream)

        Attachment #8502386 -
        Flags: review?(timdream) → review+

    
    

    
  
master,
https://github.com/mozilla-b2g/gaia/commit/c1a2f29624776da4baea74a975f4b109b55d5276

--
Thanks for the review.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S6 (10oct)

    
    

    
  
Comment on attachment 8502386 [details] [review]
Patch V1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): N/A.
[User impact] if declined: The user would need use Qwerty keyboard while they get used to Qwertz.
[Testing completed]: Yes.
[Risk to taking this patch] (and alternatives if risky): low, only layout definition file is modified.
[String changes made]: N/A

        Attachment #8502386 -
        Flags: approval-gaia-v2.1?

        Attachment #8502386 -
        Flags: approval-gaia-v2.1? → approval-gaia-v2.1+

    
    

    
  
Issue is verified fixed on Flame 2.2 KK (319mb) (Full Flash) & Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.2 KK (319mb) (Full Flash)
BuildID: 20141010040202
Gaia: 1036b544b7e102592bd9fab95cd9317329ac1293
Gecko: 50b689feab5f
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141010000201
Gaia: e52f99593e13c0c4cd6f11268af0cabd5643fecf
Gecko: 72c13d8631ff
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Pushed custom Gaia with CS keyboard. Enabled CS keyboard in settings. Launched messages and tapped on text field of new message. Switched active keyboard to Czech. Displayed keyboard is QWERTZ.

Waiting on uplift for 2.0. leaving verifyme tag
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]

          status-b2g-v2.1:
          fixed → verified

          status-b2g-v2.2:
          fixed → verified
Flags: needinfo?(ktucker)
Keywords: verifyme
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)

    
    

    
  
Removing verifyme keyword since it's not a 2.0 blocker.
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Keywords: verifyme

    
    

    
  
Is there any hope we could get some way how to switch QWERTY / QWERTZ? Pavel is right in sense that QWERTZ follows the official norm for the Czech keyboard. Except the problem is that I know many many people (especially around computers) who use QWERTY (if not for other reasons than because it is almost impossible to switch to the QWERTY keyboard when you use QWERTZ as default, and we actually don't need it for anything).

    
    

    
  
(In reply to Matěj Cepl from comment #20)
> Is there any hope we could get some way how to switch QWERTY / QWERTZ? Pavel
> is right in sense that QWERTZ follows the official norm for the Czech
> keyboard. Except the problem is that I know many many people (especially
> around computers) who use QWERTY (if not for other reasons than because it
> is almost impossible to switch to the QWERTY keyboard when you use QWERTZ as
> default, and we actually don't need it for anything).

Matěj, we could introduce another "Czech (Qwerty)" layout. Please file that bug -- you could work on it if you want to :)
Flags: needinfo?(mcepl)

    
    

    
  
Done ... bug 1096057
Flags: needinfo?(mcepl)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: