Closed Bug 1016903 Opened 5 years ago Closed 5 years ago

[appmgr v2] Missing icons

Categories

(DevTools :: WebIDE, defect)

x86_64
All
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 33

People

(Reporter: paul, Assigned: paul)

References

Details

Attachments

(1 file, 4 obsolete files)

Attached image icons.png (obsolete) —
We need more icons:
- laptop icons for local connection (the same way we have a phone icon)
- remote icons for remote connection (some sort of wire)
- info icon (like screenshot, a question mark maybe)

Attached, the current icons.
Note to myself: don't use the device icon in the runtime panel button.
Blocks: build-am2
No longer blocks: enable-webide
No longer blocks: build-am2
Attached image v2-icons (obsolete) —
New icons as requested.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Sorry, I realize that my instructions were not clear at all:

(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #0)
> We need more icons:
> - laptop icons for local connection (the same way we have a phone icon)

I meant the small phone icon, not the big one.

> - remote icons for remote connection (some sort of wire)

Same, small.

> - info icon (like screenshot, a question mark maybe)

This one is good.

And actually, thinking about it, we got a couple of things wrong in the first icons.

So here is exactly what needs to be done from attachment 8434191 [details]:
- Remove the "download" icons (icons 3x1, 3x2, 3x3)
- Remove the "big phone" icons (icons 5x1, 5x2, 5x3)
- shrink laptop icons (icons 10x1, 10x2) and remove its active state (10x3)
- shrink wire icons (icons 11x1, 11x2) and remove its active state (11x3)
- rocket icon needs to have a blue version (8x2)
- small phone icon needs to have a blue version (7x2)

To summarize:
- only 4 big icons: play / stop / pause / down-arrow. Each with 3 states
- 11 small icons: "+", folder, globe, phone, rocket, lock, camera, "v", "?", laptop, wire
- 4 of these small icons need a blue version: phone, wire, rocket, laptop 

I hope it's clear enough. If you have any question, please let me know.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Darrin, we need your help here
Flags: needinfo?(dhenein)
Attached image v2-icons-2.1.png (obsolete) —
Paul, let me know if this is better. I wasn't sure which icons needed to be the 'flat' style (the 11 in the center) or inset (the 3 big ones, the small laptop and usb). Let me know if some are not how they should be.

Flat is for use in the dropdown panels and inset is for use in the grey textured chrome.
Attachment #8434191 - Attachment is obsolete: true
Flags: needinfo?(dhenein)
(In reply to Darrin Henein [:darrin] from comment #5)
> Created attachment 8448162 [details]
> v2-icons-2.1.png
> 
> Paul, let me know if this is better. I wasn't sure which icons needed to be
> the 'flat' style (the 11 in the center) or inset (the 3 big ones, the small
> laptop and usb). Let me know if some are not how they should be.
> 
> Flat is for use in the dropdown panels and inset is for use in the grey
> textured chrome.

Darrin, this is great.

All the big icons are perfect (the blue dropdown icon is not used though).

Some of the small icons don't have the same size as the other small icons. For example the "?" icon is bigger than the phone icon. It doesn't have the same bounding box.

Can you make sure all the icons fit in a 40x40 box, and they all centered in it?

You don't have the keep the original grid layout. It might actually be easier to draw the small icons in a 40x40 grid and keep the big ones in a 100x100 grid. Up to you.

If you have time, we also need a wifi icon (new feature), the same way we have a "USB cable" icon.
Attached patch v1 (obsolete) — Splinter Review
Assignee: dhenein → paul
Attachment #8429968 - Attachment is obsolete: true
Attachment #8448162 - Attachment is obsolete: true
Status: REOPENED → ASSIGNED
Attached patch v1Splinter Review
I've use Darrin's icons and changed the layout if the icon file.
Attachment #8456100 - Attachment is obsolete: true
Attachment #8456104 - Flags: review?(jryans)
Duplicate of this bug: 1027773
Blocks: 1037115
Comment on attachment 8456104 [details] [diff] [review]
v1

Review of attachment 8456104 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!  Works correctly for WiFi devices too.
Attachment #8456104 - Flags: review?(jryans) → review+
https://hg.mozilla.org/mozilla-central/rev/cb01d0c61cca
Status: ASSIGNED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
QA Whiteboard: [qa+]
Verified that the new icons are used - Firefox 33 beta 7 (available simulators and a Flame device); Win 7 64-bit, Ubuntu 12.10 32-bit and Mac OSX 10.8.5.
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.