Closed Bug 1016906 Opened 10 years ago Closed 10 years ago

Edit button on call to translate page leads to editing English pages

Categories

(developer.mozilla.org Graveyard :: Localization, defect, P1)

Product:
developer.mozilla.org Graveyard
Component:
Localization
Platform:
All
Other
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: fs, Unassigned)

References

(
URL
)

Details

(Whiteboard: [specification][type:change][LOE:2])

What feature should be changed? Please provide the URL of the feature if possible. ================================================================================== We have a call to translation box on pages like this one: https://developer.mozilla.org/es/Firefox_OS/Developing_Firefox_OS/Quickstart_guide_to_Gaia_development The red box says "Nuestros voluntarios aún no han traducido este artículo al Español. ¡Únete a nosotros y ayuda a traducirlo!" with a link https://developer.mozilla.org/en-US/Firefox_OS/Developing_Firefox_OS/Quickstart_guide_to_Gaia_development$translate?tolocale=es But there is also the edit button, which is translated in the UI to "EDITAR" here. However, a click on "EDITAR" leads to editing the English doc: https://developer.mozilla.org/en-US/Firefox_OS/Developing_Firefox_OS/Quickstart_guide_to_Gaia_development$edit With even the button localized to "EDITAR" I propose to also link to https://developer.mozilla.org/en-US/Firefox_OS/Developing_Firefox_OS/Quickstart_guide_to_Gaia_development$translate?tolocale=es or have the button saying "Edit English document". What problems would this solve? =============================== Translators often overwrite the English page with their translation, this might be one way leading them to do that. We want to avoid that. Who would use this? =================== Translators, Editors What would users see? ===================== An "Editar" button that actually editars en espanol y no en ingles! What would users do? What would happen as a result? =================================================== Hopefully fewer translations in the original English doc. Is there anything else we should know? ======================================
URL: https://developer.mozilla.org/es/Fire...
Component: General → Localization
I don't think we should be changing the behavior of the edit button. Instead, I think we should add a "Translate" button in this situation.
Severity: normal → minor
We got five erroneous defacing in one week. This is more than usual and likely a consequence of the increase of l10n activities (both on the site and in recruiting). We need to deal with this now that we have identified the problem. It is very complex to detect the defacing (we need to check every edits), we need to fix it then, we need to create a new translated page with the translated contact and we need to contact the editor (which is cumbersome process as we have no communication mecanism built in the MDN). Basically, I do agree with Sheppy, we shouldn't change the behavior of the Edit button. We should hide it and replace it by a "Translate" button in such cases. Setting to major, it takes several hours of my time every week.
Severity: minor → major
Feedbacking Maris and Ali to define the next steps.
Flags: needinfo?(mars)
Flags: needinfo?(aspivak)
Ali, could you please add this to the most-wanted bugs list with what you feel is a suitable priority? https://etherpad.mozilla.org/mdn-projects
Flags: needinfo?(mars)
Priority: -- → P1
Whiteboard: [specification][type:change] → [specification][type:change][LOE:M]
This is a bug: But there is also the edit button, which is translated in the UI to "EDITAR" here. However, a click on "EDITAR" leads to editing the English doc: https://developer.mozilla.org/en-US/Firefox_OS/Developing_Firefox_OS/Quickstart_guide_to_Gaia_development$edit If you are in a non-english page (es, in this case,) clicking Edit should open the page in that language tree, not in the original English. It totally makes no sense it would open the parent (no wonder people are getting confused). I don't think we need to hide the button, or change the name of the button, we need it to behave as expected - open the correct version of the page, which would be /es/Firefox_OS/Developing_Firefox_OS/Quickstart_guide_to_Gaia_development.
Flags: needinfo?(aspivak)
Should this bug be added to the localization goals for Q3?
Flags: needinfo?(hoosteeno)
shobson: yes.
Adding it to the tracker for now. We will be finalizing the bugs blocking the tracker (i.e. scoping) later this week.
Blocks: mdn-l10n
Flags: needinfo?(hoosteeno)
Whiteboard: [specification][type:change][LOE:M] → [specification][type:change][LOE:2]
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/ecbcb96f81304d52cd0ba45acca7e9455dc4ad05 fix bug 1016906 - Update the button text and link https://github.com/mozilla/kuma/commit/f2ff665ced834a3a05e90151ecf652cad66e42a1 Merge pull request #2589 from darkwing/edit-link-1016906 fix bug 1016906 - Update the button text and link
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Commits pushed to github-allauth at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/ecbcb96f81304d52cd0ba45acca7e9455dc4ad05 fix bug 1016906 - Update the button text and link https://github.com/mozilla/kuma/commit/f2ff665ced834a3a05e90151ecf652cad66e42a1 Merge pull request #2589 from darkwing/edit-link-1016906
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.