Closed
Bug 1017038
Opened 10 years ago
Closed 10 years ago
[NFC] Build after f38720e3 commit fails
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(b2g-v1.2 fixed, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S3 (6june)
People
(Reporter: kamituel, Assigned: dimi)
References
Details
Attachments
(1 file, 1 obsolete file)
Doing git pull && ./repo sync -d && ./build.sh fails with:
> host C: emulator-target-arm <= external/qemu/hw/nfc-tag.c
> external/qemu/hw/nfc-tag.c:32: error: unknown field ‘t2’ specified in initializer
> external/qemu/hw/nfc-tag.c:32: warning: missing braces around initializer
> external/qemu/hw/nfc-tag.c:32: warning: (near initialization for ‘nfc_tags[0].<anonymous>.t2’)
> external/qemu/hw/nfc-tag.c:32: error: unknown field ‘t2’ specified in initializer
> external/qemu/hw/nfc-tag.c:32: error: extra brace group at end of initializer
> external/qemu/hw/nfc-tag.c:32: error: (near initialization for ‘nfc_tags[0]’)
> external/qemu/hw/nfc-tag.c:32: warning: excess elements in struct initializer
> external/qemu/hw/nfc-tag.c:32: warning: (near initialization for ‘nfc_tags[0]’)
> external/qemu/hw/nfc-tag.c:32: error: unknown field ‘t2’ specified in initializer
> external/qemu/hw/nfc-tag.c:32: error: extra brace group at end of initializer
(removing objdir doesn't help).
Once I reverted external/qemu to commit 352d873560977e765c102c6b38ab36ff02ad2de2 (so right before bug 993836 landed), it seems to compile again.
Reporter | ||
Comment 1•10 years ago
|
||
@Dimi, assigned to you, since you've been working on support for nfc type 2 tags (bug 993836).
Assignee | ||
Comment 2•10 years ago
|
||
Hi,
Could you help check if apply attached patch works ?
There is no compile error on my platform and my colleague 's platform
Flags: needinfo?(kamituel)
Reporter | ||
Comment 3•10 years ago
|
||
Hi,
yes, this patch solved it :)
Both when I've manually checked out the external/qemu to the latest HEAD from repo and built on top of my previous successfull build, and when I built from scratch (by first removing objdir).
Btw, sorry for not including my platform info:
> $ gcc -v
> Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
> Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn)
> Target: x86_64-apple-darwin13.1.0
> Thread model: posix
Mac OS X 10.9.2
Flags: needinfo?(kamituel)
Blocks: b2g-nfc
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8430487 -
Attachment is obsolete: true
Attachment #8430637 -
Flags: review?(allstars.chh)
Comment on attachment 8430637 [details] [review]
pull request for mozilla-b2g/platform_external_qemu
I don't have a Mac but it seems mac doesn't compile this with std=c11.
Attachment #8430637 -
Flags: review?(allstars.chh) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
b2g-jellybean: https://github.com/mozilla-b2g/platform_external_qemu/commit/c229a9415c8d46924b5f70e06161d7ca22b6242f
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v1.2:
--- → fixed
status-b2g-v1.3:
--- → fixed
status-b2g-v1.3T:
--- → fixed
status-b2g-v1.4:
--- → fixed
status-b2g-v2.0:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S3 (6june)
You need to log in
before you can comment on or make changes to this bug.
Description
•