1017129 - Polish undo close tab button toast appearance

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[:Margaret Leibovic]

Follow-up to bug 701725.

We should also audit the other button toasts to make sure they're consistently capitalized.

Comment 2

[:Margaret Leibovic]

Ian, can I get an icon for this? I will also gladly make any other necessary style changes :)

Comment 3

[Nick Alexander :nalexander [he/him]]

redirecting to antlam, who's been cranking out icons and keeping our visual style consistent.

margaret, can you a) audit other uses of ButtonToast here, and b) make sure I merged your oneline and ellipsize styles into ButtonMessage correctly?  I'm a good reviewer for this, too :)

Comment 4

[Ian Barlow (:ibarlow)]

Anthony, mind putting an Undo icon together here? Should probably somewhat resemble what android uses http://cl.ly/image/1u0y2m3q2J3G

Comment 5

[Ian Barlow (:ibarlow)]

Haha. Jinx!

Comment 6

[Nick Alexander :nalexander [he/him]]

(In reply to Ian Barlow (:ibarlow) from comment #4)
> Anthony, mind putting an Undo icon together here? Should probably somewhat
> resemble what android uses http://cl.ly/image/1u0y2m3q2J3G

I see from this screenshot that v19+ toasts are transparent, looks like black and alpha is 50% or so.  antlam, what say you?  Can you give this a whirl on a v19+ and <v19 device?

Comment 7

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Nick Alexander :nalexander from comment #6)
> (In reply to Ian Barlow (:ibarlow) from comment #4)
> > Anthony, mind putting an Undo icon together here? Should probably somewhat
> > resemble what android uses http://cl.ly/image/1u0y2m3q2J3G
> 
> I see from this screenshot that v19+ toasts are transparent, looks like
> black and alpha is 50% or so.  antlam, what say you?  Can you give this a
> whirl on a v19+ and <v19 device?

In reply to both of yous - yes!

Nick, I've noticed this too. I was just going to say ours should probably be about the same transparency.

Comment 8

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Hey Margaret, I'm also noticing that the undo brings the "just closed" tab down to the bottom of the list. Is this intentional or? I'm thinking if it might be beneficial to restoring the tab to the previous order in the list.. thoughts?

Comment 9

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Hey Margaret, I'm also noticing that the undo brings the "just closed" tab down to the bottom of the list. Is this intentional or? I'm thinking if it might be beneficial to restoring the tab to the previous order in the list.. thoughts?

Comment 10

[:Margaret Leibovic]

(In reply to Anthony Lam (:antlam) from comment #9)
> Hey Margaret, I'm also noticing that the undo brings the "just closed" tab
> down to the bottom of the list. Is this intentional or? I'm thinking if it
> might be beneficial to restoring the tab to the previous order in the list..
> thoughts?

We should file a separate bug for that. That would require a fix to the session store code that stores and restores the tab.

Comment 11

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: Screen Shot 2014-05-29 at 12.57.22 PM.png

Here goes the "undo" icon. I designed it to take from our existing forwards/backwards icon. I think the curved trajectory provides the idea of movement and really helps to keep it whimsical. 

As a side note, this also keeps our "types of arrows" count relatively low still and will draw a nice connection to an "export" arrow if we ever decide we need one prominently.

Comment 12

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: undo_icon.zip

Here they are from MDPI > XXHDPI

Comment 13

[:Margaret Leibovic]

Attachment: Polish undo close tab button toast appearance

Comment 14

[:Margaret Leibovic]

I decided not to rev the string entity because this string just landed yesterday, so I don't think localizers would have looked at it yet. It also might not change in all locales. flod, can you tell me if this logic is wrong? If so, I'll update the patch to give the entity a new name.

Comment 15

[:Margaret Leibovic]

I thought we set this to track 32 in triage today. Setting the flag now.

Comment 16

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8431251 [details] [diff] [review]
Polish undo close tab button toast appearance

Review of attachment 8431251 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm.  I suggest revving the entity anyway; if it's gone before l10n teams see it, that's fine.

Comment 17

[:Margaret Leibovic]

(In reply to Nick Alexander :nalexander from comment #16)
> Comment on attachment 8431251 [details] [diff] [review]
> Polish undo close tab button toast appearance
> 
> Review of attachment 8431251 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> lgtm.  I suggest revving the entity anyway; if it's gone before l10n teams
> see it, that's fine.

Fair enough, it's not actually that much effort :)

Comment 18

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/3540dc826ca8

Comment 19

[Francesco Lodolo [:flod]]

The rule in general is to change the string ID if it already landed on mozilla-central. We have fast localizers, sometimes an hour is enough to get the strings localized ;-)

Comment 20

[Paul [pwd]]

(In reply to Anthony Lam (:antlam) from comment #11)
> Created attachment 8431066 [details]
> Screen Shot 2014-05-29 at 12.57.22 PM.png
> 
> Here goes the "undo" icon. I designed it to take from our existing
> forwards/backwards icon. I think the curved trajectory provides the idea of
> movement and really helps to keep it whimsical. 
> 
> As a side note, this also keeps our "types of arrows" count relatively low
> still and will draw a nice connection to an "export" arrow if we ever decide
> we need one prominently.

I don't get the desire to go against platform convention. We can add the arrow head to the Android undo and harmonize the user experience. Here you're attempting to a/ redefine the undo icon completely. Check pretty much any application on any platform. And b/ require Android users to think about the action they're taking. That's two major negatives for very little upside.

Comment 21

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3540dc826ca8

Comment 22

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Paul [pwd] from comment #20)

> I don't get the desire to go against platform convention. We can add the
> arrow head to the Android undo and harmonize the user experience. Here
> you're attempting to a/ redefine the undo icon completely. Check pretty much
> any application on any platform. And b/ require Android users to think about
> the action they're taking. That's two major negatives for very little upside.

An image search for "android undo" shows that the Google apps use the undo image you favor, but other applications use other undo images. I'm not sure it's a true platform convention yet.

Comment 23

[Paul [pwd]]

(In reply to Mark Finkle (:mfinkle) from comment #22)
> (In reply to Paul [pwd] from comment #20)
> 
> > I don't get the desire to go against platform convention. We can add the
> > arrow head to the Android undo and harmonize the user experience. Here
> > you're attempting to a/ redefine the undo icon completely. Check pretty much
> > any application on any platform. And b/ require Android users to think about
> > the action they're taking. That's two major negatives for very little upside.
> 
> An image search for "android undo" shows that the Google apps use the undo
> image you favor, but other applications use other undo images. I'm not sure
> it's a true platform convention yet.

Image search "android reply"...

Comment 24

[Ian Barlow (:ibarlow)]

Thanks for your input, Paul. You're right, undo and reply icons are often used similarly, not just on Android but everywhere. It's worth remembering however that in this case the word "undo" is right next to the icon as well. :)  So I don't think we'll be making any changes here right away, but we will be watching for feedback from other users and can iterate if necessary. 

And as a matter of housekeeping, since this bug is now closed, any additional visual changes will be handled in separate follow ups.

Comment 25

[Paul [pwd]]

Sorry Ian, one last comment as the icon in question kind of got implemented very quickly, then this was closed and I actually feel quite strongly about this. Every modern Android phone comes with Gmail, Email which both feature a reply button like our undo button and  with the addition of Chrome, an undo button that is also shipped in the icon pack. That's a huge precedence to go against. As stated before, there is clearly no upside to the current icon which goes against such a precedence (if one has been made, please point me to it). If we're relying on text to diminish ambiguity, we're clearly doing something wrong. Taking a closer look at the "Android Undo" image search result, reveals many of the 'reply' icons are from iOS and general web icon searches (please not there is no such ambiguity in the "Android Reply" image search results. We have a responsibility to provide users with a user experience that harmonises with the operating system and insistence on shipping the a reply icon for an undo action goes against that as much as waiting for feedback to fix a UX issue that need not make its way beyond the Nightly channel.

Comment 26

[Aaron Train [:aaronmt]]

Yeah there is the Android drawable (ic_menu_revert) that we should be using (if it is public)

Comment 27

[Wesley Johnston (:wesj)]

(In reply to Aaron Train [:aaronmt] from comment #26)
> Yeah there is the Android drawable (ic_menu_revert) that we should be using
> (if it is public)

These icons are meant for menus not toasts. We'd probably ship our own version of it if we do switch.