1017134 - Yahoo! Mail is not working on today's Nightly

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[alex_mayorga]

Steps:
 - Sign-in into https://mail.yahoo.com/
 - Try to open an e-mail from the list

Results:
The message viewer remains blank and after about a minute the basic UI is offered.

Expected results:
The message viewer shows the selected message.

Web Console output:

"DARLA notice: 427" combo:1
"DARLA notice: 414" combo:1
"DARLA notice: 434" combo:1
"DARLA notice: 404" combo:1
TypeError: e.config.doc.defaultView.getComputedStyle is not a function combo:16
"DARLA notice: 510" combo:1

3rd party confirmation at http://forums.mozillazine.org/viewtopic.php?p=13583447#p13583447

Comment 1

[Alice0775 White]

Error in Browser Console when open the url:

"Exception in use comms-ui-tooltips-widget with args comms-ui-tooltips-widget,minty_module_offscreen_bin_convs_callout_rollup,minty_module_offscreen_bin_themes_callout_rollup: TypeError: e.config.doc.defaultView.getComputedStyle is not a function" combo:2

TypeError: e.config.doc.defaultView.getComputedStyle is not a function combo:16


Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3f2754fcfb8
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140526074421
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2587cd80a66e
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140526090920
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a3f2754fcfb8&tochange=2587cd80a66e

Regressed by:
2587cd80a66e	Peter Van der Beken — Bug 789261 - Enable WebIDL bindings for Window. r=bz.

Comment 2

[Peter Van der Beken [:peterv]]

getComputedStyle is definitely gone, trying to find out why.

Comment 3

[Peter Van der Beken [:peterv]]

Here's the code that deletes window.getComputedStyle (pretified from https://s.yimg.com/zz/combo?nq/s/launch/inbox-base_54_1034.js):

    if (window.hasOwnProperty && window.hasOwnProperty('getComputedStyle')) {
      var D = window.getComputedStyle,
      C = window.Window || Object.getPrototypeOf(window);
      delete window.getComputedStyle;
      C.getComputedStyle = function (I, J) {
        return D.call(this || window, I, J);
      };
    }

Note that C is set to window.Window if it exists (it does in Gecko) and getComputedStyle is then set as a property on that. Which of course doesn't make window.getComputedStyle work, for that they'd have to make that third line be |C = window.Window.prototype || Object.getPrototypeOf(window);|. This looks like a bug in the script, and I'm not sure we can do much about it.

Boris, any bright ideas?

Comment 4

[Boris Zbarsky [:bzbarsky]]

In no particular order of insanity:

1)  Make getComputedStyle non-configurable (but writable).
2)  Make getComputedStyle unforgeable.
3)  Make window.Window falsy.
4)  Move all methods back to the prototype.
5)  Move only getComputedStyle back to the prototype.
6)  Make the window resolve hook notice if someone deleted getComputedStyle and make it
    reappear on the window.
7)  Make the gsp notice if someone deleted getComputedStyle and make it appear on the
    gsp.

If we really cared, we could restrict any of those to just the Yahoo site, I guess.

Also, long-term I assume we're just going to evangelize Yahoo here, so we just need a short-term workaround?

Comment 5

[alex_mayorga]

Boris,

FWIW I "tweeted"(1) Yahoo! to fix this, so you might want to outline what exactly needs fixing on their script.

1 https://twitter.com/alex_mayorga/status/472045781432938498

Comment 6

[Boris Zbarsky [:bzbarsky]]

See comment 3.  This buggy line:

      C = window.Window || Object.getPrototypeOf(window);

should be replaced by this one:

      C = (window.Window && window.Window.prototype) || Object.getPrototypeOf(window);

Comment 7

[Mike Taylor [:miketaylr]]

Hi Brian, Do you think you could point this bug to someone on the Mail team? Thanks!

Comment 8

[alex_mayorga]

FWIW, I've filed incident 140529-029736 using https://help.yahoo.com/kb/helpcentral

It said they'll contact me on my Yahoo! Mail that I can't access =D

Comment 9

[Brian J.]

I've filed a bug to the mail team on our internal tracking system.  For reference, the bug ID is 6965711.  I'll try and get some eyes on this as soon as I can.

Comment 11

[alex_mayorga]

FWIW when the loading takes too long eventually https://mx-mg6.mail.yahoo.com/neo/b/launch it's offered that loads a simpler version of Yahoo! Mail that doesn't have the bug.

Comment 12

[Milan Sreckovic [:milan] (needinfo for best results)]

Should we consider backing out Bug 789261 at this point?  Seems like a week of not supporting a major e-mail service, knowing what caused the regression is getting a bit long, and we're less than a week away from Aurora - we wouldn't let this problem go to Aurora, right?

Comment 13

[Boris Zbarsky [:bzbarsky]]

> Should we consider backing out Bug 789261 at this point? 

No, we should consider doing one of the workarounds from comment 4 until Yahoo fixes their script.

Comment 15

[Brian J.]

In our internal bug tracking system, this issue has been marked RESOLVED FIXED.

Comment 16

[Peter Van der Beken [:peterv]]

(In reply to Brian J. from comment #15)
> In our internal bug tracking system, this issue has been marked RESOLVED
> FIXED.

Does that mean the fix was pushed to production? Because it's still broken for me.

Comment 18

[Peter Van der Beken [:peterv]]

Attachment: v1

Let's do this while we're waiting on the fix from Yahoo.

Comment 19

[Mike Taylor [:miketaylr]]

(In reply to Peter Van der Beken [:peterv] from comment #16)
> (In reply to Brian J. from comment #15)
> > In our internal bug tracking system, this issue has been marked RESOLVED
> > FIXED.
> 
> Does that mean the fix was pushed to production? Because it's still broken
> for me.

It will probably take a while to roll out to production servers (anywhere from days to weeks), based on previous experience with these types of issues.

Comment 20

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8435776 [details] [diff] [review]
v1

Oh, I like this piggybacking on the Xray code.  ;)

The only worry is whether something in XrayResolveNativeProperty depends on "wrapper" being an actual Xray.  At first glance, looks like no: it just uses it as the parent for functions.

r=me

Comment 21

[Boris Zbarsky [:bzbarsky]]

Oh, actually: could we add a warning here, so the Yahoo people realize this is still being a problem?

Comment 22

[sachristan]

(In reply to Boris Zbarsky [:bz] from comment #21)
> Oh, actually: could we add a warning here, so the Yahoo people realize this
> is still being a problem?

Yahoo Mail just started working for me again with the latest Nightly update. (6/06 8:00p.m. EST, second or third update of the day).

Comment 23

[IU]

I too can confirm that Yahoo mail is working again, so I guess that extra patch may no longer be needed.

Comment 24

[sap7772000-zilla]

Hello guys.
I use now 32.0a1 (2014-06-07) and I confirm Y Mail works as expected.
Thank you for your swift reaction.
Best regards.

Comment 25

[alex_mayorga]

It's working now on Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140609030202 CSet: 9305a8ec77fe

Comment 26

[Mike Aguilar]

Yahoo Mail is working again. I am now on 32.0a1 (2014-06-09) after having updated twice. Thank you.