1017242 - Eliminate Android 2.2 (API 8) code

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

We ended 2.2 support in Firefox 31. Let's use this bug to track removal of any API 8 code from the codebase in 32 and up.

Comment 1

[Richard Newman [:rnewman]]

See Bug 717691, Bug 730851, Bug 720471.

Comment 2

[Richard Newman [:rnewman]]

mobile/android/base/widget/TwoWayView.java
1061:        if (Build.VERSION.SDK_INT < 9) {
1072:        if (Build.VERSION.SDK_INT < 9) {
3145:        if (Build.VERSION.SDK_INT >= 5) {

mobile/android/base/webapp/Allocator.java
79:        if (android.os.Build.VERSION.SDK_INT > 8) {

mobile/android/base/util/GamepadUtils.java
27:        if (Build.VERSION.SDK_INT >= 9) {
50:        if (Build.VERSION.SDK_INT < 9) {

mobile/android/base/tests/testBrowserProvider.java
540:            if (Build.VERSION.SDK_INT >= 8 &&
644:            if (Build.VERSION.SDK_INT >= 8 &&

mobile/android/base/tests/testGetUserMedia.java
21:        if (Build.VERSION.SDK_INT >= 9) {

mobile/android/base/SysInfo.java.in
50:        if (android.os.Build.VERSION.SDK_INT < 9) {

mobile/android/base/mozglue/GeckoLoader.java.in
88:            if (Build.VERSION.SDK_INT >= 8) {

mobile/android/base/GeckoSharedPrefs.java
153:        if (Build.VERSION.SDK_INT < 9) {

mobile/android/base/gfx/LayerView.java
146:        if (Build.VERSION.SDK_INT >= 9) {
670:        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.GINGERBREAD) {
684:        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.GINGERBREAD) {

mobile/android/base/health/BrowserHealthRecorder.java
342:        if (android.os.Build.VERSION.SDK_INT < android.os.Build.VERSION_CODES.GINGERBREAD) {

mobile/android/base/sync/setup/activities/LocaleAware.java
31:    if (Build.VERSION.SDK_INT < Build.VERSION_CODES.GINGERBREAD) {

mobile/android/base/GeckoAppShell.java
719:        if (Build.VERSION.SDK_INT < 9) {
732:        if (Build.VERSION.SDK_INT < 9) {
2200:        if (Build.VERSION.SDK_INT >= 9) {
2207:            if (Build.VERSION.SDK_INT >= 9)
2479:        if (Build.VERSION.SDK_INT >=Build.VERSION_CODES.FROYO)
2514:        if (Build.VERSION.SDK_INT >=Build.VERSION_CODES.FROYO)

mobile/android/base/db/BrowserDatabaseHelper.java
95:        if (Build.VERSION.SDK_INT >= 8) {
133:        if (Build.VERSION.SDK_INT >= 8) {

mobile/android/base/CrashReporter.java
247:        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.GINGERBREAD) {
395:            if (Build.VERSION.SDK_INT >= 8) {

mobile/android/base/BrowserApp.java
293:        if (Build.VERSION.SDK_INT >= 9 &&

mobile/android/base/background/healthreport/HealthReportDatabaseStorage.java
237:    public static boolean CAN_USE_ABSOLUTE_DB_PATH = (Build.VERSION.SDK_INT >= Build.VERSION_CODES.FROYO);

mobile/android/base/AndroidGamepadManager.java
304:        if (Build.VERSION.SDK_INT < 9) {

plus a bunch in GeckoApp.

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to Richard Newman [:rnewman] from comment #2)
> mobile/android/base/widget/TwoWayView.java
> 1061:        if (Build.VERSION.SDK_INT < 9) {
> 1072:        if (Build.VERSION.SDK_INT < 9) {
> 3145:        if (Build.VERSION.SDK_INT >= 5) {

FYI: TwoWayView should be considered a third-party dependency. So, please don't touch it while fixing this bug as the upstream project still needs to support Froyo.

Comment 4

[Richard Newman [:rnewman]]

Attachment: Part 1: remove API 8 code from mozglue

Comment 5

[Richard Newman [:rnewman]]

Attachment: Part 2: remove API 8 code from GeckoApp and BrowserApp

Comment 6

[Richard Newman [:rnewman]]

Attachment: Part 3: remove API 8 code from gfx

Comment 7

[Richard Newman [:rnewman]]

Attachment: Part 4: remove API 8 code from GeckoAppShell

Comment 8

[Richard Newman [:rnewman]]

Attachment: Part 5: remove API 8 code from gamepad code

Comment 9

[Richard Newman [:rnewman]]

Attachment: Part 6: remove API 8 code from BrowserHealthRecorder

Comment 10

[Richard Newman [:rnewman]]

Attachment: Part 7: remove API 8 code from GeckoSharedPrefs

Comment 11

[Richard Newman [:rnewman]]

Attachment: Part 8: remove API 8 code from CrashReporter

Comment 12

[Richard Newman [:rnewman]]

Attachment: Part 9: remove API 8 code from SysInfo

Comment 13

[Richard Newman [:rnewman]]

Attachment: Part A: remove API 8 code from webapp Allocator

Comment 14

[Richard Newman [:rnewman]]

Attachment: Part B: remove API 8 code from toolbar

Comment 15

[Richard Newman [:rnewman]]

Attachment: Part C: remove API 8 code from GeckoEvent

Comment 16

[Richard Newman [:rnewman]]

Attachment: Part D: remove API 8 code from BrowserDatabaseHelper

Comment 17

[Richard Newman [:rnewman]]

https://hg.mozilla.org/try/rev/ba0d3e5999f1
https://hg.mozilla.org/try/rev/bb03504eeb4b
https://hg.mozilla.org/try/rev/3e637dcd1670
https://hg.mozilla.org/try/rev/9f3ca0ba9b5c
https://hg.mozilla.org/try/rev/c13fcfa8eef5
https://hg.mozilla.org/try/rev/8a7d1c69619b
https://hg.mozilla.org/try/rev/919297388b57
https://hg.mozilla.org/try/rev/64839801308c
https://hg.mozilla.org/try/rev/bd63aa5b253b
https://hg.mozilla.org/try/rev/73cc4755e814
https://hg.mozilla.org/try/rev/df7761a47498
https://hg.mozilla.org/try/rev/ea65e3220f1c
https://hg.mozilla.org/try/rev/95b38c650c6a

Comment 18

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8458261 [details] [diff] [review]
Part 5: remove API 8 code from gamepad code

Review of attachment 8458261 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/util/GamepadUtils.java
@@ +26,3 @@
>      private static boolean isGamepadKey(KeyEvent event) {
> +        if (Build.VERSION.SDK_INT < 12) {
> +            return false;

Why return false for < 12?

Comment 19

[Richard Newman [:rnewman]]

That constant isn't defined until API 12. in other words: Eclipse spotted a crash bug.

Comment 20

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8458261 [details] [diff] [review]
Part 5: remove API 8 code from gamepad code

Review of attachment 8458261 [details] [diff] [review]:
-----------------------------------------------------------------

I doubt it would crash; doesn't the constant get inlined at compile time? So compiling using an SDK > v12 should work on a runtime < v12, it would just presumably always return false in that case. Nevertheless this is better.

Comment 21

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8458257 [details] [diff] [review]
Part 1: remove API 8 code from mozglue

Do we need the fallbacks? Does getExternalStoragePublicDirectory return null?

Comment 22

[Richard Newman [:rnewman]]

(In reply to Mark Finkle (:mfinkle) from comment #21)

> Do we need the fallbacks? Does getExternalStoragePublicDirectory return null?

I can only presume that they're there for a reason. That reason *might* have been because someone was too lazy to add an `else` clause. I'll look deeper, but perhaps not in this bug.

Comment 23

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8458258 [details] [diff] [review]
Part 2: remove API 8 code from GeckoApp and BrowserApp

Review of attachment 8458258 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoApp.java
@@ +2376,5 @@
>              try {
>                  obj.put("lac", gcl.getLac());
>                  obj.put("cid", gcl.getCid());
>  
> +                int psc = gcl.getPsc();

I don't see this line but rnewman said on irc that it was gone in his latest rebase on fx-team so this should be removed from the patch.

Comment 24

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/a8a119f236f5
https://hg.mozilla.org/integration/fx-team/rev/4ed35c44168f
https://hg.mozilla.org/integration/fx-team/rev/5a01eb70b82c
https://hg.mozilla.org/integration/fx-team/rev/5be4171df691
https://hg.mozilla.org/integration/fx-team/rev/33dd5214acd8
https://hg.mozilla.org/integration/fx-team/rev/f9c02d1852de
https://hg.mozilla.org/integration/fx-team/rev/f9ec00de92c5
https://hg.mozilla.org/integration/fx-team/rev/c3cde1547d1d
https://hg.mozilla.org/integration/fx-team/rev/6bfbded8be02
https://hg.mozilla.org/integration/fx-team/rev/8bb625db4015
https://hg.mozilla.org/integration/fx-team/rev/6d78d2be19f6
https://hg.mozilla.org/integration/fx-team/rev/f0fb51922868
https://hg.mozilla.org/integration/fx-team/rev/537990bf7786

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a8a119f236f5
https://hg.mozilla.org/mozilla-central/rev/4ed35c44168f
https://hg.mozilla.org/mozilla-central/rev/5a01eb70b82c
https://hg.mozilla.org/mozilla-central/rev/5be4171df691
https://hg.mozilla.org/mozilla-central/rev/33dd5214acd8
https://hg.mozilla.org/mozilla-central/rev/f9c02d1852de
https://hg.mozilla.org/mozilla-central/rev/f9ec00de92c5
https://hg.mozilla.org/mozilla-central/rev/c3cde1547d1d
https://hg.mozilla.org/mozilla-central/rev/6bfbded8be02
https://hg.mozilla.org/mozilla-central/rev/8bb625db4015
https://hg.mozilla.org/mozilla-central/rev/6d78d2be19f6
https://hg.mozilla.org/mozilla-central/rev/f0fb51922868
https://hg.mozilla.org/mozilla-central/rev/537990bf7786