1017328 - [Flatfish] PDF files render incorrectly in the browser app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::PDF Viewer, defect)

Description

[Guilherme Gonçalves [:ggp]]

Steps to reproduce:

1- Open the browser app
2- Navigate to a PDF file (I can consistently reproduce this with https://crypto.stanford.edu/craig/easy-fhe.pdf , for example)
3- The file gets rendered incorrectly.

OS version
1.4.0.0-prerelease

Git commit info:
2014-01-20 07:27:55
62f5852a

Comment 1

[Raniere Silva]

Attachment: bug-pdf.png

This bug can also be reproduce at

OS version: 2.1.0.0-prerelese
Hardware revision: flatfish
Platform version: 33.0a1
Build Identifier: 20140618202826
Gaia Identifier: 2014-06-18 20:14:05 2526b49a

Comment 2

[Raniere Silva]

Attachment: screenshot of pdf at hamachi (no bug)

I can't reproduce this bug at hamachi:

B2G: b91a268d3415fd5eec2fab45d3072067e8c0b33d
Gecko: a16e68c38aabd1d9c86c8a6fa4e8291dbefeb59e
Gaia: 2b1524b9bd1c321d40fe0bea0e26bc2f00f74919

Comment 3

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Can you provide a test URL?

Comment 4

[Guilherme Gonçalves [:ggp]]

Do you mean a PDF file that reproduces the issue? I provided one in the initial report: https://crypto.stanford.edu/craig/easy-fhe.pdf

Thanks for looking into this!

Comment 5

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Awesome. I can also reproduce this. Maybe the pdf.js version needs to be updated for the devices.

Comment 6

[Benlamara]

the problem happens just with Pdfs with images and layers

Comment 7

[Benlamara]

Attachment: the bug in Flatfish 2.1

Comment 8

[yifan [:yifan][:yliao]]

Attachment: pull request

Updating pdf.js to version 1.0.524 fix the problem.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8466071 [details] [review]
pull request

I'm fine on the principle but I would prefer bdhal or yury to validate that this version works as expected and does not have some bad surprises for Gaia.

Comment 10

[Yury Delendik (:yury)]

Comment on attachment 8466071 [details] [review]
pull request

ffos has its own viewer that is created by running `node make b2g`. the pull request replaces b2g with the standard one, which is too heavy for ffos.

Comment 11

[yifan [:yifan][:yliao]]

Comment on attachment 8466071 [details] [review]
pull request

Thank you for the correction.
Updated the pdf.js version with 'node make b2g'.

Comment 12

[Yury Delendik (:yury)]

Comment on attachment 8466071 [details] [review]
pull request

Looks good when CSS conflict resolved

Comment 13

[Yan Or]

Yi-Fan,

Do you mind updating to the latest pdf.js master?  It includes a patch for bug 1054590 which fixes gaia bug 1016817.

Thanks.

Comment 14

[yifan [:yifan][:yliao]]

Thanks for the suggestion. I'll update it and the pull request to be reviewed.

Comment 15

[yifan [:yifan][:yliao]]

Comment on attachment 8466071 [details] [review]
pull request

Update pdf.js to version 1.0.700 to use the new web component based header (gaia-header)

I'm not sure if you'd like the 2 commits be squashed into one. Please feel free to advice. Thank you!

Comment 16

[Yury Delendik (:yury)]

Comment on attachment 8466071 [details] [review]
pull request

Looks good

> I'm not sure if you'd like the 2 commits be squashed into one. Please feel
> free to advice. Thank you!

I have no preference on squashing.

Comment 17

[yifan [:yifan][:yliao]]

Merged into master
https://github.com/mozilla-b2g/gaia/pull/22397

TBPL
https://tbpl.mozilla.org/?rev=a67d38ab74f48b2b1d2330fb0517aaa1c85c52a6&tree=Gaia-Try

Comment 18

[yifan [:yifan][:yliao]]

Backout commit: 721809bad3fc5fcaf00f7b25cacccfab2ff9c499

This commit updated pdf.js to version 1.0.700 which also fixed bug 1016817. But produced bug 1056989. Reverting to 1.0.524 reopens bug 1016817. This bug is unaffected.

Comment 19

[Shally Li（leave from Mozilla）]

Per Comment 18 ("This bug is unaffected"), clear verifyme and modify status to VERIFIED FIXED.