Remove the dom.window_experimental_bindings pref

RESOLVED FIXED in mozilla35

Status

()

defect
RESOLVED FIXED
5 years ago
4 months ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

unspecified
mozilla35
x86
macOS
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(10 attachments, 3 obsolete attachments)

2.62 KB, patch
peterv
: review+
Details | Diff | Splinter Review
6.04 KB, patch
peterv
: review+
Details | Diff | Splinter Review
3.21 KB, patch
peterv
: review+
Details | Diff | Splinter Review
1.05 KB, patch
peterv
: review+
Details | Diff | Splinter Review
2.84 KB, patch
peterv
: review+
Details | Diff | Splinter Review
5.15 KB, patch
peterv
: review+
Details | Diff | Splinter Review
2.92 KB, patch
peterv
: review+
Details | Diff | Splinter Review
5.21 KB, patch
Details | Diff | Splinter Review
1.54 KB, patch
bholley
: review+
Details | Diff | Splinter Review
44.03 KB, patch
peterv
: review+
Details | Diff | Splinter Review
Once we do that, we can start assuming Window has WebIDL bindings and, for example, do things like make window.performance StoreInSlot.
Blocks: 1017425
Blocks: 1012798
Blocks: 1042654
Flags: needinfo?(peterv)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8483000 - Flags: review?(peterv)
Flags: needinfo?(peterv)
Comment on attachment 8482998 [details] [diff] [review]
part 3.  Remove the now-unnecessary nsIDocument::WrapObject

Review of attachment 8482998 [details] [diff] [review]:
-----------------------------------------------------------------

Can you make nsINode::WrapObject MOZ_FINAL now?
Comment on attachment 8483000 [details] [diff] [review]
part 5.  Remove classinfo for Window

Review of attachment 8483000 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsDOMClassInfo.h
@@ +228,5 @@
>    }
>  };
>  
> +// A place to hang some static methods that we should really consider
> +// moving to be nsGlobalWindow member methods.

File a bug? Should be easy, I suspect.

::: dom/base/nsGlobalWindow.cpp
@@ +13770,5 @@
>  
>  // nsGlobalModalWindow implementation
>  
>  // QueryInterface implementation for nsGlobalModalWindow
>  DOMCI_DATA(ModalContentWindow, nsGlobalModalWindow)

Do we need this?
> Can you make nsINode::WrapObject MOZ_FINAL now?

No, because Element needs to override to do custom element stuff.      

> File a bug? Should be easy, I suspect.

It involves moving a bunch of code...  But sure, bug 1062418 and I updated the comment to reference it.

> Do we need this?

No.  Removed all three DOMCI_DATA, good catch.
Blocks: 1062418
Attachment #8483602 - Flags: review?(peterv)
Attachment #8483000 - Attachment is obsolete: true
Attachment #8483000 - Flags: review?(peterv)
Attachment #8484189 - Flags: review?(peterv)
Attachment #8483602 - Attachment is obsolete: true
Attachment #8483602 - Flags: review?(peterv)
Bobby, with these patches js/xpconnect/tests/chrome/test_bug763343.xul fails because the QI to nsIClassInfo fails.

Any preferences for how I should modify that test?  DOM classinfo is going away... We have other classinfo things around (e.g. some storage stuff), but those might not be singletons.
Flags: needinfo?(bobbyholley)
Attachment #8484193 - Flags: review?(bobbyholley) → review+
(In reply to Boris Zbarsky [:bz] from comment #16)
> Bobby, with these patches js/xpconnect/tests/chrome/test_bug763343.xul fails
> because the QI to nsIClassInfo fails.
> 
> Any preferences for how I should modify that test?  DOM classinfo is going
> away... We have other classinfo things around (e.g. some storage stuff), but
> those might not be singletons.

Maybe the console service? http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsConsoleService.cpp#38
Flags: needinfo?(bobbyholley)
Hmm.  If I force isClassInfoSingleton to false in XPCWrappedNative::GetNewOrUsed that test still passes (without these patches).  Bobby, is that expected?
Flags: needinfo?(bobbyholley)
Attachment #8484189 - Attachment is obsolete: true
Attachment #8484189 - Flags: review?(peterv)
(In reply to Boris Zbarsky [:bz] from comment #18)
> Hmm.  If I force isClassInfoSingleton to false in
> XPCWrappedNative::GetNewOrUsed that test still passes (without these
> patches).  Bobby, is that expected?

Per IRC discussion, I think this is fine.
Flags: needinfo?(bobbyholley)
Attachment #8482996 - Flags: review?(peterv) → review+
Attachment #8482997 - Flags: review?(peterv) → review+
Attachment #8482998 - Flags: review?(peterv) → review+
Attachment #8482999 - Flags: review?(peterv) → review+
Attachment #8483002 - Flags: review?(peterv) → review+
Attachment #8483003 - Flags: review?(peterv) → review+
Attachment #8483004 - Flags: review?(peterv) → review+
Blocks: 1063521
Attachment #8484355 - Flags: review?(peterv) → review+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.